You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 05:11:32 UTC
[GitHub] [kylin] kyotoYaho opened a new pull request #1153: KYLIN-4407
Protect query engine to provide more stable service
kyotoYaho opened a new pull request #1153: KYLIN-4407 Protect query engine to provide more stable service
URL: https://github.com/apache/kylin/pull/1153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1153: KYLIN-4407 Protect
query engine to provide more stable service
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1153: KYLIN-4407 Protect query engine to provide more stable service
URL: https://github.com/apache/kylin/pull/1153#issuecomment-596955931
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=h1) Report
> Merging [#1153](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `21.7%`.
[](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1153 +/- ##
============================================
+ Coverage 25.05% 25.06% +<.01%
- Complexity 6248 6255 +7
============================================
Files 1446 1447 +1
Lines 88305 88378 +73
Branches 12357 12358 +1
============================================
+ Hits 22128 22154 +26
- Misses 64007 64054 +47
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.19% <0%> (-0.07%)` | `44 <0> (ø)` | |
| [...ain/java/org/apache/kylin/common/QueryContext.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/common/QueryContextFacade.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHRGYWNhZGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/common/SubThreadPoolExecutor.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9TdWJUaHJlYWRQb29sRXhlY3V0b3IuamF2YQ==) | `61.53% <61.53%> (ø)` | `7 <7> (?)` | |
| [...in/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL0N1YmVIQmFzZUVuZHBvaW50UlBDLmphdmE=) | `8.7% <8.51%> (+0.79%)` | `4 <0> (ø)` | :arrow_down: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1153/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=footer). Last update [ebc4c26...ea40f0c](https://codecov.io/gh/apache/kylin/pull/1153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1153: KYLIN-4407 Protect
query engine to provide more stable service
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1153: KYLIN-4407 Protect query engine to provide more stable service
URL: https://github.com/apache/kylin/pull/1153#issuecomment-596959087
## Pull Request Test Coverage Report for [Build 5729](https://coveralls.io/builds/29242846)
* **28** of **129** **(21.71%)** changed or added relevant lines in **6** files are covered.
* **8** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.008%**) to **27.526%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/QueryContextFacade.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FQueryContextFacade.java#L41) | 0 | 3 | 0.0%
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1370) | 0 | 5 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29242846/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L409) | 0 | 12 | 0.0%
| [core-common/src/main/java/org/apache/kylin/common/SubThreadPoolExecutor.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FSubThreadPoolExecutor.java#L56) | 24 | 39 | 61.54%
| [core-common/src/main/java/org/apache/kylin/common/QueryContext.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FQueryContext.java#L62) | 0 | 23 | 0.0%
| [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java](https://coveralls.io/builds/29242846/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2FCubeHBaseEndpointRPC.java#L95) | 4 | 47 | 8.51%
<!-- | **Total:** | **28** | **129** | **21.71%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-common/src/main/java/org/apache/kylin/common/QueryContextFacade.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FQueryContextFacade.java#L102) | 1 | 0% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29242846/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29242846/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L408) | 2 | 0% |
| [core-common/src/main/java/org/apache/kylin/common/QueryContext.java](https://coveralls.io/builds/29242846/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FQueryContext.java#L79) | 3 | 0% |
<!-- | **Total:** | **8** | | -->
| Totals | [](https://coveralls.io/builds/29242846) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | 0.008% |
| Covered Lines: | 24327 |
| Relevant Lines: | 88378 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services