[GitHub] [spark] HyukjinKwon commented on a change in pull request #26730: [SPARK-30091][SQL][Python] Document mergeSchema option directly in the Python API

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26730: [SPARK-30091][SQL][Python] Document mergeSchema option directly in the Python API
URL: https://github.com/apache/spark/pull/26730#discussion_r352405238
 
 

 ##########
 File path: python/pyspark/sql/readwriter.py
 ##########
 @@ -300,18 +300,20 @@ def table(self, tableName):
         return self._df(self._jreader.table(tableName))
 
     @since(1.4)
-    def parquet(self, *paths):
 
 Review comment:
   I think this `*paths` allows a consistent way with Scala and Java side (`def parquet(paths: String*)`). So I think technically it's more correct to support `*paths`.
   
   In case of streaming, it's also matched to Scala / Java side `def parquet(path: String)`.
   
   Maybe we should introduce keyword-only argument (as you said earlier somewhere) after completely dropping Python 2 in Spark 3.1. ... I am not sure about this yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org