You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Diar Ahmed <di...@oracle.com> on 2010/05/18 04:39:30 UTC
[Trinidad] - Any objections / counter-proposals for (TRINIDAD-1810)
Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet()
apis]
Hi Trinidad Developers,
I just filed (TRINIDAD-1810) -
<https://issues.apache.org/jira/browse/TRINIDAD-1810> Flash component
needs public version of
NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
<https://issues.apache.org/jira/browse/TRINIDAD-1810> and was wondering
if anybody has any objections or counter-proposals for addressing this
issue.
Thanks,
Diar
-------- Original Message --------
Subject: [jira] Created: (TRINIDAD-1810) Flash component needs public
version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
Date: Mon, 17 May 2010 17:40:41 -0400 (EDT)
From: Diar Ahmed (JIRA) <de...@myfaces.apache.org>
To: diar.ahmed@oracle.com
Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
-----------------------------------------------------------------------------------------------------
Key: TRINIDAD-1810
URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
Project: MyFaces Trinidad
Issue Type: Improvement
Components: Components
Affects Versions: 1.2.14-core
Environment: All
Reporter: Diar Ahmed
Priority: Blocker
ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
MinimumFractionDigits
MaximumFractionDigits
MinimumIntegerDigits
MaximumIntegerDigits
since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
- protected boolean isMaximumFractionDigitsSet()
- protected boolean isMinimumFractionDigitsSet()
- protected boolean isMaximumIntegerDigitsSet()
- protected boolean isMinimumIntegerDigitsSet()
This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [Trinidad][api] - Any objections / counter-proposals for (TRINIDAD-1810)
Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet()
apis]
Posted by Diar Ahmed <di...@oracle.com>.
Hi All,
I have attached a patch for this issue for trunk as well as the1.2.12.3
branch. It would be great if somebody could commit these patches.
Thanks,
Diar
Diar Ahmed wrote:
> Hi Again,
>
> So what we would like to do to fix this issue is to make the following
> methods on NumberConverter public.
> - protected boolean isMaximumFractionDigitsSet()
> - protected boolean isMinimumFractionDigitsSet()
> - protected boolean isMaximumIntegerDigitsSet()
> - protected boolean isMinimumIntegerDigitsSet()
>
> will become
>
> - public boolean isMaximumFractionDigitsSet()
> - public boolean isMinimumFractionDigitsSet()
> - public boolean isMaximumIntegerDigitsSet()
> - public boolean isMinimumIntegerDigitsSet()
>
>
> If this sounds ok, we will go ahead and make this change.
>
> Thanks,
> Diar
>
> Diar Ahmed wrote:
>> Resending with [api] to be more specific about this request.
>>
>> Thanks,
>> Diar
>> Diar Ahmed wrote:
>>> Hi Trinidad Developers,
>>>
>>> I just filed (TRINIDAD-1810) -
>>> <https://issues.apache.org/jira/browse/TRINIDAD-1810> Flash
>>> component needs public version of
>>> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>>> <https://issues.apache.org/jira/browse/TRINIDAD-1810> and was
>>> wondering if anybody has any objections or counter-proposals for
>>> addressing this issue.
>>>
>>> Thanks,
>>> Diar
>>>
>>> -------- Original Message --------
>>> Subject: [jira] Created: (TRINIDAD-1810) Flash component needs
>>> public version of
>>> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>>> Date: Mon, 17 May 2010 17:40:41 -0400 (EDT)
>>> From: Diar Ahmed (JIRA) <de...@myfaces.apache.org>
>>> To: diar.ahmed@oracle.com
>>>
>>>
>>>
>>> Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>>> -----------------------------------------------------------------------------------------------------
>>>
>>> Key: TRINIDAD-1810
>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
>>> Project: MyFaces Trinidad
>>> Issue Type: Improvement
>>> Components: Components
>>> Affects Versions: 1.2.14-core
>>> Environment: All
>>> Reporter: Diar Ahmed
>>> Priority: Blocker
>>>
>>>
>>> ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
>>>
>>> This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
>>> MinimumFractionDigits
>>> MaximumFractionDigits
>>> MinimumIntegerDigits
>>> MaximumIntegerDigits
>>> since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
>>>
>>> Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
>>> - protected boolean isMaximumFractionDigitsSet()
>>> - protected boolean isMinimumFractionDigitsSet()
>>> - protected boolean isMaximumIntegerDigitsSet()
>>> - protected boolean isMinimumIntegerDigitsSet()
>>>
>>> This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
Re: [Trinidad][api] - Any objections / counter-proposals for (TRINIDAD-1810) Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis]
Posted by Blake Sullivan <bl...@oracle.com>.
+1
-- Blake Sullivan
On May 26, 2010, at 5:33 AM, Matthias Wessendorf wrote:
> +1
>
> On Wed, May 26, 2010 at 1:54 PM, Diar Ahmed <di...@oracle.com> wrote:
> Hi Again,
>
> So what we would like to do to fix this issue is to make the following methods on NumberConverter public.
> - protected boolean isMaximumFractionDigitsSet()
> - protected boolean isMinimumFractionDigitsSet()
> - protected boolean isMaximumIntegerDigitsSet()
> - protected boolean isMinimumIntegerDigitsSet()
>
> will become
>
> - public boolean isMaximumFractionDigitsSet()
> - public boolean isMinimumFractionDigitsSet()
> - public boolean isMaximumIntegerDigitsSet()
> - public boolean isMinimumIntegerDigitsSet()
>
> If this sounds ok, we will go ahead and make this change.
>
> Thanks,
> Diar
>
> Diar Ahmed wrote:
>>
>> Resending with [api] to be more specific about this request.
>>
>> Thanks,
>> Diar
>> Diar Ahmed wrote:
>>>
>>> Hi Trinidad Developers,
>>>
>>> I just filed (TRINIDAD-1810) - Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis and was wondering if anybody has any objections or counter-proposals for addressing this issue.
>>>
>>> Thanks,
>>> Diar
>>>
>>> -------- Original Message --------
>>> Subject: [jira] Created: (TRINIDAD-1810) Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>>> Date: Mon, 17 May 2010 17:40:41 -0400 (EDT)
>>> From: Diar Ahmed (JIRA) <de...@myfaces.apache.org>
>>> To: diar.ahmed@oracle.com
>>>
>>> Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>>> -----------------------------------------------------------------------------------------------------
>>>
>>> Key: TRINIDAD-1810
>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
>>> Project: MyFaces Trinidad
>>> Issue Type: Improvement
>>> Components: Components
>>> Affects Versions: 1.2.14-core
>>> Environment: All
>>> Reporter: Diar Ahmed
>>> Priority: Blocker
>>>
>>>
>>> ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
>>>
>>> This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
>>> MinimumFractionDigits
>>> MaximumFractionDigits
>>> MinimumIntegerDigits
>>> MaximumIntegerDigits
>>> since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
>>>
>>> Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
>>> - protected boolean isMaximumFractionDigitsSet()
>>> - protected boolean isMinimumFractionDigitsSet()
>>> - protected boolean isMaximumIntegerDigitsSet()
>>> - protected boolean isMinimumIntegerDigitsSet()
>>>
>>> This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
Re: [Trinidad][api] - Any objections / counter-proposals for
(TRINIDAD-1810) Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet()
apis]
Posted by Matthias Wessendorf <ma...@apache.org>.
+1
On Wed, May 26, 2010 at 1:54 PM, Diar Ahmed <di...@oracle.com> wrote:
> Hi Again,
>
> So what we would like to do to fix this issue is to make the following
> methods on NumberConverter public.
>
> - protected boolean isMaximumFractionDigitsSet()
> - protected boolean isMinimumFractionDigitsSet()
> - protected boolean isMaximumIntegerDigitsSet()
> - protected boolean isMinimumIntegerDigitsSet()
>
> will become
>
> - public boolean isMaximumFractionDigitsSet()
> - public boolean isMinimumFractionDigitsSet()
> - public boolean isMaximumIntegerDigitsSet()
> - public boolean isMinimumIntegerDigitsSet()
>
>
> If this sounds ok, we will go ahead and make this change.
>
> Thanks,
> Diar
>
> Diar Ahmed wrote:
>
> Resending with [api] to be more specific about this request.
>
> Thanks,
> Diar
> Diar Ahmed wrote:
>
> Hi Trinidad Developers,
>
> I just filed (TRINIDAD-1810) -<https://issues.apache.org/jira/browse/TRINIDAD-1810>Flash component needs public version of
> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis<https://issues.apache.org/jira/browse/TRINIDAD-1810>and was wondering if anybody has any objections or counter-proposals for
> addressing this issue.
>
> Thanks,
> Diar
>
> -------- Original Message -------- Subject: [jira] Created:
> (TRINIDAD-1810) Flash component needs public version of
> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis Date: Mon,
> 17 May 2010 17:40:41 -0400 (EDT) From: Diar Ahmed (JIRA)
> <de...@myfaces.apache.org> <de...@myfaces.apache.org> To:
> diar.ahmed@oracle.com
>
> Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
> -----------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1810
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.2.14-core
> Environment: All
> Reporter: Diar Ahmed
> Priority: Blocker
>
>
> ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
>
> This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
> MinimumFractionDigits
> MaximumFractionDigits
> MinimumIntegerDigits
> MaximumIntegerDigits
> since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
>
> Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
> - protected boolean isMaximumFractionDigitsSet()
> - protected boolean isMinimumFractionDigitsSet()
> - protected boolean isMaximumIntegerDigitsSet()
> - protected boolean isMinimumIntegerDigitsSet()
>
> This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [Trinidad][api] - Any objections / counter-proposals for (TRINIDAD-1810)
Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet()
apis]
Posted by Diar Ahmed <di...@oracle.com>.
Hi Again,
So what we would like to do to fix this issue is to make the following
methods on NumberConverter public.
- protected boolean isMaximumFractionDigitsSet()
- protected boolean isMinimumFractionDigitsSet()
- protected boolean isMaximumIntegerDigitsSet()
- protected boolean isMinimumIntegerDigitsSet()
will become
- public boolean isMaximumFractionDigitsSet()
- public boolean isMinimumFractionDigitsSet()
- public boolean isMaximumIntegerDigitsSet()
- public boolean isMinimumIntegerDigitsSet()
If this sounds ok, we will go ahead and make this change.
Thanks,
Diar
Diar Ahmed wrote:
> Resending with [api] to be more specific about this request.
>
> Thanks,
> Diar
> Diar Ahmed wrote:
>> Hi Trinidad Developers,
>>
>> I just filed (TRINIDAD-1810) -
>> <https://issues.apache.org/jira/browse/TRINIDAD-1810> Flash component
>> needs public version of
>> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>> <https://issues.apache.org/jira/browse/TRINIDAD-1810> and was
>> wondering if anybody has any objections or counter-proposals for
>> addressing this issue.
>>
>> Thanks,
>> Diar
>>
>> -------- Original Message --------
>> Subject: [jira] Created: (TRINIDAD-1810) Flash component needs
>> public version of
>> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>> Date: Mon, 17 May 2010 17:40:41 -0400 (EDT)
>> From: Diar Ahmed (JIRA) <de...@myfaces.apache.org>
>> To: diar.ahmed@oracle.com
>>
>>
>>
>> Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
>> -----------------------------------------------------------------------------------------------------
>>
>> Key: TRINIDAD-1810
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
>> Project: MyFaces Trinidad
>> Issue Type: Improvement
>> Components: Components
>> Affects Versions: 1.2.14-core
>> Environment: All
>> Reporter: Diar Ahmed
>> Priority: Blocker
>>
>>
>> ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
>>
>> This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
>> MinimumFractionDigits
>> MaximumFractionDigits
>> MinimumIntegerDigits
>> MaximumIntegerDigits
>> since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
>>
>> Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
>> - protected boolean isMaximumFractionDigitsSet()
>> - protected boolean isMinimumFractionDigitsSet()
>> - protected boolean isMaximumIntegerDigitsSet()
>> - protected boolean isMinimumIntegerDigitsSet()
>>
>> This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
[Trinidad][api] - Any objections / counter-proposals for (TRINIDAD-1810)
Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet()
apis]
Posted by Diar Ahmed <di...@oracle.com>.
Resending with [api] to be more specific about this request.
Thanks,
Diar
Diar Ahmed wrote:
> Hi Trinidad Developers,
>
> I just filed (TRINIDAD-1810) -
> <https://issues.apache.org/jira/browse/TRINIDAD-1810> Flash component
> needs public version of
> NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
> <https://issues.apache.org/jira/browse/TRINIDAD-1810> and was
> wondering if anybody has any objections or counter-proposals for
> addressing this issue.
>
> Thanks,
> Diar
>
> -------- Original Message --------
> Subject: [jira] Created: (TRINIDAD-1810) Flash component needs public
> version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
> Date: Mon, 17 May 2010 17:40:41 -0400 (EDT)
> From: Diar Ahmed (JIRA) <de...@myfaces.apache.org>
> To: diar.ahmed@oracle.com
>
>
>
> Flash component needs public version of NumberConverter.is[Min/Max][Fraction/Integer]DigitsSet() apis
> -----------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1810
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1810
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.2.14-core
> Environment: All
> Reporter: Diar Ahmed
> Priority: Blocker
>
>
> ADF Faces has a number of components ( Graph, Gauge, ... ) that accept NumberConverters in order to support number formatting. These converters can be used on the middle tier to support PNG generation, but for Flash based rendering, the NumberConverter's properties are read in the middle tier and pass down to an existing ActionScript number formatting engine.
>
> This JIRA is to support the ability to determine whether the the following properties are set on the NumberConverter and should be transferred to Actionscript:
> MinimumFractionDigits
> MaximumFractionDigits
> MinimumIntegerDigits
> MaximumIntegerDigits
> since by default, if these properties are not set, they always return 0, which is not the correct min/max fraction/integer digits used by the NumberConverter.
>
> Currently, the NumberConverter has protected methods that provide access to whether these properties are set:
> - protected boolean isMaximumFractionDigitsSet()
> - protected boolean isMinimumFractionDigitsSet()
> - protected boolean isMaximumIntegerDigitsSet()
> - protected boolean isMinimumIntegerDigitsSet()
>
> This JIRA is requesting that these APIs ( or alternate APIs ) are made public, to allow us to determine if these attributes are set and should be used when we perform ActionScript based formatting.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>