You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/11 00:54:29 UTC
[GitHub] [airflow] wolfier opened a new pull request #15316: Add links to new modules for deprecated modules
wolfier opened a new pull request #15316:
URL: https://github.com/apache/airflow/pull/15316
closes: #14394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#discussion_r611114767
##########
File path: airflow/contrib/hooks/aws_hook.py
##########
@@ -30,7 +30,10 @@
class AwsHook(AwsBaseHook):
- """This class is deprecated. Please use `airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`."""
+ """
+ This class is deprecated.
+ Please use `airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`.
Review comment:
```suggestion
Please use :class:`airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`.
```
I think this should work? Same for other deprecated classes below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#discussion_r611174087
##########
File path: airflow/operators/redshift_to_s3_operator.py
##########
@@ -32,10 +32,9 @@
class RedshiftToS3Transfer(RedshiftToS3Operator):
- """This class is deprecated.
-
- Please use:
- `airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.
+ """
+ This class is deprecated.
+ Please use: :mod:`airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.
Review comment:
```suggestion
Please use: :class:`airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.
```
##########
File path: airflow/contrib/hooks/gcp_compute_hook.py
##########
@@ -31,7 +31,7 @@
class GceHook(ComputeEngineHook):
"""
This class is deprecated.
- Please use ``airflow.providers.google.cloud.hooks.compute.ComputeEngineHook``.
+ Please use `airflow.providers.google.cloud.hooks.compute.ComputeEngineHook`.
Review comment:
```suggestion
Please use :class:`airflow.providers.google.cloud.hooks.compute.ComputeEngineHook`.
```
##########
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##########
@@ -29,7 +29,10 @@
class DataFlowHook(DataflowHook):
- """This class is deprecated. Please use `airflow.providers.google.cloud.hooks.dataflow.DataflowHook`."""
+ """
+ This class is deprecated.
+ Please use `airflow.providers.google.cloud.hooks.dataflow.DataflowHook`.
Review comment:
```suggestion
Please use :class:`airflow.providers.google.cloud.hooks.dataflow.DataflowHook`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#issuecomment-817228608
@kaxil @mik-laj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#discussion_r611174221
##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -15,7 +15,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""This module is deprecated. Please use `kubernetes.client.models for V1ResourceRequirements and Port."""
+"""
+This module is deprecated.
+Please use :mod:`kubernetes.client.models for V1ResourceRequirements and Port.
Review comment:
This does not look right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15316:
URL: https://github.com/apache/airflow/pull/15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15316: Add links to new modules for deprecated modules
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#discussion_r611174239
##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -15,7 +15,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""This module is deprecated. Please use `kubernetes.client.models for V1ResourceRequirements and Port."""
+"""
+This module is deprecated.
+Please use :mod:`kubernetes.client.models for V1ResourceRequirements and Port.
Review comment:
```suggestion
Please use :mod:`kubernetes.client.models` for V1ResourceRequirements and Port.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org