[GitHub] [incubator-hudi] yihua commented on issue #1239: [HUDI-551] Abstract a test case class for DFS Source to make it extensible

[GitBox <gi...@apache.org>]

yihua commented on issue #1239: [HUDI-551] Abstract a test case class for DFS Source to make it extensible
URL: https://github.com/apache/incubator-hudi/pull/1239#issuecomment-575857464
 
 
   Thanks for the suggestions, @yanghua !
   
   So here's a list of proposed changes based on your comments:
   - Create a new class `AbstractDFSSourceTestBase` based on `DFSSourceTestCase` in the last commit
   - The common test logic still resides in `AbstractDFSSourceTestBase`
   - For each DFS Source class, extend from `AbstractDFSSourceTestBase` to add source-specific test logic
   
   Let me know if this looks good.  I'll start rearranging the code and go from there.
   
   Btw, the CSV Source PR (HUDI-76) depends on this.  It would be good if we can iterate quickly on this one to get it merged :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services