You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/16 01:05:25 UTC
[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #2725: fix #2449:It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.
lgcareer opened a new pull request #2725:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2725
## What is the purpose of the pull request
*add the filter of user*
## Brief change log
*It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #2725: fix #2449:It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2725:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2725#issuecomment-629567047
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=h1) Report
> Merging [#2725](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=desc) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/90d1701ad5aa6816e36c9c13d37a634e32f59fc5&el=desc) will **increase** coverage by `1.04%`.
> The diff coverage is `37.80%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-1.3.0 #2725 +/- ##
===============================================
+ Coverage 36.14% 37.19% +1.04%
- Complexity 2470 2544 +74
===============================================
Files 431 433 +2
Lines 19862 19932 +70
Branches 2422 2427 +5
===============================================
+ Hits 7180 7413 +233
+ Misses 12038 11847 -191
- Partials 644 672 +28
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `78.16% <0.00%> (ø)` | `33.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `71.17% <0.00%> (ø)` | `66.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/remote/command/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ29tbWFuZFR5cGUuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dolphinscheduler/service/log/LogClientService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvbG9nL0xvZ0NsaWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lphinscheduler/service/process/ProcessService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...inscheduler/service/quartz/ProcessScheduleJob.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L1Byb2Nlc3NTY2hlZHVsZUpvYi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...inscheduler/server/log/LoggerRequestProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2xvZy9Mb2dnZXJSZXF1ZXN0UHJvY2Vzc29yLmphdmE=) | `37.83% <47.36%> (+37.83%)` | `5.00 <0.00> (+5.00)` | |
| [...emote/command/log/RemoveTaskLogRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvbG9nL1JlbW92ZVRhc2tMb2dSZXF1ZXN0Q29tbWFuZC5qYXZh) | `76.92% <76.92%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [30 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=footer). Last update [c08fa12...d60abc1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #2725: fix #2449:It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2725:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2725#issuecomment-629567430
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2725&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2725&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2725&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2725&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2725&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #2725: fix #2449:It's should successful to cancel authorize a resource of a user if all the online process definitions created by this user didn't use this resource.
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #2725:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org