[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #7033: [minor] test cleanup

[GitBox <gi...@apache.org>]

the-other-tim-brown commented on code in PR #7033:
URL: https://github.com/apache/hudi/pull/7033#discussion_r1002537771


##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsSource.java:
##########
@@ -63,14 +60,8 @@ public static void beforeAll() throws Exception {
     UtilitiesTestBase.initTestServices(false, false);
   }
 
-  @AfterAll
-  public static void afterAll() {

Review Comment:
   These parent methods were all being called twice since the test is extending UtilitiesTestBase



##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deser/TestKafkaAvroSchemaDeserializer.java:
##########
@@ -45,7 +44,7 @@
 /**
  * Tests {@link KafkaAvroSchemaDeserializer}.
  */
-public class TestKafkaAvroSchemaDeserializer extends UtilitiesTestBase {
+public class TestKafkaAvroSchemaDeserializer {

Review Comment:
   The UtilitiesTestBase was just adding unneeded overhead to this test



##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieIndexer.java:
##########
@@ -100,6 +101,16 @@ public void init() throws IOException {
     initMetaClient();
   }
 
+  @AfterAll
+  public static void cleanup() {

Review Comment:
   The spark context wasn't being closed which could cause other tests to fail that tried to create their own context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org