[GitHub] [lucene-solr] janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r309926547
 
 

 ##########
 File path: solr/CHANGES.txt
 ##########
 @@ -57,6 +57,8 @@ Upgrade Notes
 
 * SOLR-13596: Deprecated GroupingSpecification methods are removed. (Munendra S N)
 
+* SOLR-13649: When Basic Authentication is enabled, users will be required to enter credentials to access the Admin UI and associated operations by default. The blockUnknown parameter can still be set to false to disable the need to authenticate. (marcussorealheis) 
 
 Review comment:
   I'd simply write **BasicAuth property 'blockUknown' now defaults to 'true'** here. Then add a section under "Upgrade Notes" where you describe how this is backward incompatible, i.e. if you need `blockUnknown=false` behavior it must now be explicitly stated in `security.json`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org