You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2024/06/17 01:54:18 UTC

[PR] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

coderzc opened a new pull request, #22921:
URL: https://github.com/apache/pulsar/pull/22921

   This reverts commit c81c0f684f8c55c2e39739c6e1de935dff2085d6.
   
   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   <!-- Either this PR fixes an issue, -->
   
   Fixes #xyz
   
   <!-- or this PR is one task of an issue -->
   
   Main Issue: #xyz
   
   <!-- If the PR belongs to a PIP, please add the PIP link here -->
   
   PIP: #xyz 
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
   
   ### Motivation
   
   #22867 introduced some break changes, such as `bin/pulsar zookeeper-shell --run-one "ls /ledgers"` can't work after introduced 22867.
   
   
   ### Modifications
   
   Revert #22867
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22921:
URL: https://github.com/apache/pulsar/pull/22921#issuecomment-2172031026

   @coderzc Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22921:
URL: https://github.com/apache/pulsar/pull/22921#issuecomment-2172651928

   > #22867 introduced some break changes, such as `bin/pulsar zookeeper-shell --run-one "ls /ledgers"` can't work after introduced 22867.
   
   @coderzc @RobertIndie @merlimat I don't agree with reverting this change. The syntax of `bin/pulsar zookeeper-shell --run-one "ls /ledgers"` is simply wrong. It just happened to work before when the shell script didn't correctly handle parameters. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22921:
URL: https://github.com/apache/pulsar/pull/22921#issuecomment-2402347380

   @coderzc Please review #22923. Reverting the shell script was not the correct solution to address this problem. I've explained in #22923 and also comments above. I'd like to finally fix the shell script syntax for Pulsar 4.0.0 so that it's not forever invalid. There's no need to cherry-pick to older versions if that's a concern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc closed pull request #22921: Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)"
URL: https://github.com/apache/pulsar/pull/22921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc merged PR #22921:
URL: https://github.com/apache/pulsar/pull/22921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22921:
URL: https://github.com/apache/pulsar/pull/22921#issuecomment-2172954405

   The `--run-once "ls /path"` syntax is supported for the Python based zk-shell, https://pypi.org/project/zk-shell/ . That's not used when `pulsar zookeeper-shell` is called.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22921:
URL: https://github.com/apache/pulsar/pull/22921#issuecomment-2172692935

   There are several problems with `bin/pulsar zookeeper-shell --run-one "ls /ledgers"`
   
   1. `zookeeper-shell` has never supported an option called `--run-one`
   2. The parameter for zookeeper-shell shouldn't be quoted.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org