You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/03 15:22:08 UTC
[PR] Move cluster lock strategy SPI to cluster mode core [shardingsphere]
terrymanu opened a new pull request, #40043:
URL: https://github.com/apache/shardingsphere/pull/40043
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cluster lock strategy SPI to cluster mode core [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40043:
URL: https://github.com/apache/shardingsphere/pull/40043#issuecomment-5970545877
### Result
**Review Result: Mergeable**
ClusterLockStrategy now belongs to cluster-mode-core. Its interface signature and locking behavior remain unchanged. No blocking issues were introduced by this change. This conclusion covers local code only.
### Evidence
- Moved the interface to mode/type/cluster/core. Updated imports in LockClusterExecutor, both Proxy strategies, and their tests. Renamed the META-INF/services descriptor while preserving its provider entries.
- test-compile passed for all three affected modules. ClusterReadWriteLockStrategyTest, ClusterWriteLockStrategyTest, and LockClusterExecutorTest passed all 8 tests. All commands exited with code 0.
- spotless:check and checkstyle:check (-Pcheck -T1C) passed for exactly the 6 changed Java files. Reports confirmed that the modules selected 1, 1, and 4 files respectively. Repository-wide apache-rat:check (-Pcheck -T1C) also passed. All commands exited with code 0.
- Comparison against the baseline confirmed that only the package name, imports, and service descriptor path changed. No source references to the old package remain. Existing dependencies and distribution configuration were checked. No additional runtime cost was introduced.
- The SPI's fully qualified class name changed as intended. External custom implementations must update their imports and service descriptor filenames.
### Coverage
Standalone local candidate based on 53db60ad1de8. Reviewed all 9 paths representing 7 logical files: relocation of the interface and service descriptor, plus import updates in the executor, two implementations, and two tests. No commits or staging changes were made for this task. Unrelated changes were excluded. Ownership, contracts and impact, tests and runtime paths, and final convergence were reviewed. Coverage ledger validation passed. Remote CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cluster lock strategy SPI to cluster mode core [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40043:
URL: https://github.com/apache/shardingsphere/pull/40043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org