You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "bvfalcon (via GitHub)" <gi...@apache.org> on 2023/03/27 18:36:30 UTC
[GitHub] [tapestry-5] bvfalcon opened a new pull request, #36: TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
bvfalcon opened a new pull request, #36:
URL: https://github.com/apache/tapestry-5/pull/36
https://issues.apache.org/jira/browse/TAP5-2749 -- fix with controlling integration test for this bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[GitHub] [tapestry-5] vjlamp commented on pull request #36: TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
Posted by "vjlamp (via GitHub)" <gi...@apache.org>.
vjlamp commented on PR #36:
URL: https://github.com/apache/tapestry-5/pull/36#issuecomment-1519174483
Hello Vladimir, thank you for picking up my suggestions. I realized only tonight that it's possible for me to commit to PRs. So that's what I did, simplifying the test a little bit more.
I have the entire Tapestry tests ensemble running locally at the moment (just one more time). When all tests pass, I'll merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[GitHub] [tapestry-5] vjlamp merged pull request #36: TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
Posted by "vjlamp (via GitHub)" <gi...@apache.org>.
vjlamp merged PR #36:
URL: https://github.com/apache/tapestry-5/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[GitHub] [tapestry-5] bvfalcon commented on pull request #36: TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
Posted by "bvfalcon (via GitHub)" <gi...@apache.org>.
bvfalcon commented on PR #36:
URL: https://github.com/apache/tapestry-5/pull/36#issuecomment-1518982496
> making a small addition to the existing test app 6 would be nicer.
In case of all tests in app6 are independent from each other this is absolutely true. But tests JpaIntegrationTestWithAnnotationsInServiceImplementation.persist_entities and SessionApplicationStatePersistenceStrategyTest.check collidieren one to another: first sets session variable, second checks this variable on starting. Adding `deleteAllVisibleCookies();` in the start of second test solves this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org