You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Mesos ReviewBot <de...@mesos.apache.org> on 2015/02/04 05:26:17 UTC
Re: Review Request 30601: Updated slave to use Executor/Task grace
period, with a maximum.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review70922
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30579, 30580, 30583, 30595, 30596, 30597, 30601]
All tests passed.
- Mesos ReviewBot
On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30601/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:14 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2228
> https://issues.apache.org/jira/browse/MESOS-2228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the slave doesn't completely ignore the grace period, note that there is a bound of 1 minute for now.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec
> src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443
> src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504
> src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794
> src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6
> src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134
> src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
> src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6
>
> Diff: https://reviews.apache.org/r/30601/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>