You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mark Struberg <st...@yahoo.de> on 2011/10/25 10:07:02 UTC
Commit r1188515
------------------------------------------------------------------------
r1188515 | lu4242 | 2011-10-25 07:13:01 +0200 (Di, 25 Okt 2011) | 1 line
MYFACES-3368 enable 'standard' checkstyle checks in myfaces-core (revert some changes on LocaleUtils because it is a copy of a class in commons-lang, so it is better to keep it without changes, fix UIComponentTagBase signature and some intentional usages of final modifier)
Leo, if you like to explicitely like to treat some files different, then please add them to the exclude section in the maven-checkstyle-plugin config.
txs and LieGrue,
strub
Re: Commit r1188515
Posted by Leonardo Uribe <lu...@gmail.com>.
Note I only change the final modifiers, not the variable renaming. At
least in the structure we just keep it in sync. Really there is only
one method used, so the remaining code is not relevant.
2011/10/25 Mark Struberg <st...@yahoo.de>:
> I now compared our version with the one (actually two, lang and lang3) from commons, and although one can see that they have common origins, they are now pretty different already. Thus I see no reason why not to drop the _ from the variable names.
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Mark Struberg <st...@yahoo.de>
>> To: myfaces-dev <de...@myfaces.apache.org>
>> Cc:
>> Sent: Tuesday, October 25, 2011 10:07 AM
>> Subject: Commit r1188515
>>
>> ------------------------------------------------------------------------
>> r1188515 | lu4242 | 2011-10-25 07:13:01 +0200 (Di, 25 Okt 2011) | 1 line
>>
>> MYFACES-3368 enable 'standard' checkstyle checks in myfaces-core (revert
>> some changes on LocaleUtils because it is a copy of a class in commons-lang, so
>> it is better to keep it without changes, fix UIComponentTagBase signature and
>> some intentional usages of final modifier)
>>
>> Leo, if you like to explicitely like to treat some files different, then please
>> add them to the exclude section in the maven-checkstyle-plugin config.
>>
>> txs and LieGrue,
>> strub
>>
>
Re: Commit r1188515
Posted by Mark Struberg <st...@yahoo.de>.
I now compared our version with the one (actually two, lang and lang3) from commons, and although one can see that they have common origins, they are now pretty different already. Thus I see no reason why not to drop the _ from the variable names.
LieGrue,
strub
----- Original Message -----
> From: Mark Struberg <st...@yahoo.de>
> To: myfaces-dev <de...@myfaces.apache.org>
> Cc:
> Sent: Tuesday, October 25, 2011 10:07 AM
> Subject: Commit r1188515
>
> ------------------------------------------------------------------------
> r1188515 | lu4242 | 2011-10-25 07:13:01 +0200 (Di, 25 Okt 2011) | 1 line
>
> MYFACES-3368 enable 'standard' checkstyle checks in myfaces-core (revert
> some changes on LocaleUtils because it is a copy of a class in commons-lang, so
> it is better to keep it without changes, fix UIComponentTagBase signature and
> some intentional usages of final modifier)
>
> Leo, if you like to explicitely like to treat some files different, then please
> add them to the exclude section in the maven-checkstyle-plugin config.
>
> txs and LieGrue,
> strub
>