You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/06 07:15:31 UTC

[GitHub] [incubator-yunikorn-core] yangwwei opened a new pull request #97: Fix flaky unit tests on master branch

yangwwei opened a new pull request #97: Fix flaky unit tests on master branch
URL: https://github.com/apache/incubator-yunikorn-core/pull/97
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-core] wilfred-s commented on issue #97: Fix flaky unit tests on master branch

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on issue #97: Fix flaky unit tests on master branch
URL: https://github.com/apache/incubator-yunikorn-core/pull/97#issuecomment-595710395
 
 
   The fact that the tests now pass shows that there is a timing issue and that the code is not really broken.
   Not sure how to track this down.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-core] yangwwei closed pull request #97: Fix flaky unit tests on master branch

Posted by GitBox <gi...@apache.org>.
yangwwei closed pull request #97: Fix flaky unit tests on master branch
URL: https://github.com/apache/incubator-yunikorn-core/pull/97
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-core] yangwwei commented on issue #97: Fix flaky unit tests on master branch

Posted by GitBox <gi...@apache.org>.
yangwwei commented on issue #97: Fix flaky unit tests on master branch
URL: https://github.com/apache/incubator-yunikorn-core/pull/97#issuecomment-595913403
 
 
   I had some time yesterday so I created this PR to narrow down the UT issue.
   In our smoke test, TestBasicScheduler, TestReservation stuff can fail intermittently. I tried to run these tests locally lots of times, I can sometimes reproduce. E.g
   
   `go test -count=20 -run TestBasicScheduler`
   
   By increasing the count number, I see more weird things happening. So far, not many progress.. We've been such smoke tests for a while, there must be something changed after https://github.com/apache/incubator-yunikorn-core/pull/89.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org