You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/07 06:31:57 UTC
[GitHub] [incubator-inlong] fuweng11 opened a new pull request, #4104: [INLONG-4077] Implement the APIs of data node management
fuweng11 opened a new pull request, #4104:
URL: https://github.com/apache/incubator-inlong/pull/4104
### Title Name: [INLONG-4077][component] Implement the APIs of data node management
where *XYZ* should be replaced by the actual issue number.
Fixes #4077
### Motivation
Implement the APIs of data node management
### Modifications
Implement the APIs of DataNodeServiceImpl and modify some parameters of DataNodeController
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [X] This change added tests and can be verified as follows:
`org.apache.inlong.manager.service.core.impl.DataNodeServiceTest`
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #4104: [INLONG-4077][Manager] Implement the APIs of data node management
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #4104:
URL: https://github.com/apache/incubator-inlong/pull/4104#issuecomment-1120196288
Please do not change the format of the SQL file, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4104: [INLONG-4077][Manager] Implement the APIs of data node management
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4104:
URL: https://github.com/apache/incubator-inlong/pull/4104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4104: [INLONG-4077][Manager] Implement the APIs of data node management
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4104:
URL: https://github.com/apache/incubator-inlong/pull/4104#discussion_r867351957
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataNodeEntityMapper.java:
##########
@@ -35,4 +38,8 @@ public interface DataNodeEntityMapper {
int deleteById(Integer id);
-}
\ No newline at end of file
+ DataNodeEntity selectByUniqueKey(DataNodeRequest request);
Review Comment:
Please reuse the `selectByNameAndType` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org