You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2016/06/01 07:47:08 UTC

Re: [PATCH] clean up release notes - pass 3

On Mon, May 16, 2016 at 03:44:58PM +0200, Stefan wrote:
>   (issues): rename section id so it doesn't start with a number

Is breaking section links like the one below worth it?

It's not going to be a big problem for people to locate the right
section on the page even if this link changes. But on the other hand,
it's not a big problem if this page isn't 100% XHTML compliant, is it?

> @@ -2463,9 +2460,9 @@
>  <p>There are some known issues in the Subversion 1.8 releases.  These
>  may be fixed in later 1.8.x releases.</p>
>  
> -<div class="h3" id="411-length-required">
> +<div class="h3" id="length-required-411">
>  <h3>1.8.0 and chunked Transfer-Encoding
> -  <a class="sectionlink" href="#411-length-required"
> +  <a class="sectionlink" href="#length-required-411"
>      title="Link to this section">&para;</a>
>  </h3>
>  
> @@ -2529,7 +2526,7 @@
>  href="http://mail-archives.apache.org/mod_mbox/subversion-dev/201307.mbox/%3cCADkdwvQUaWaC5=AvwsthjSQWcn48tKHVfWoVCUHjLT=Abu13YA@mail.gmail.com>">this dev@ list post</a> for an example.</p>
>  
>  
> -</div>  <!-- 411-length-required -->
> +</div>  <!-- length-required-411 -->
>  
>  <div class="h3" id="mod_dav_svn-fsmap">
>  <h3>mod_dav_svn Maps Requests to Local Filesystem




RE: [PATCH] clean up release notes - pass 3

Posted by Bert Huijben <be...@qqmail.nl>.

> -----Original Message-----
> From: Stefan Hett [mailto:stefan@egosoft.com]
> Sent: woensdag 1 juni 2016 15:17
> To: dev@subversion.apache.org
> Subject: Re: [PATCH] clean up release notes - pass 3
> 


> I made my call here, but I can also fully understand if the rest of the
> world sees it different than I do. ;-)

Given that all newer browsers must support it, the older browsers did and
the link existed for some years, I would recommend just keeping the link
working.

And I don't see a good reason to add an additional link to make theoretical
browsers work... If we can find a browser that breaks, sure..
(Given the transfer from <A NAME=>, which did support numbers if I remember
correctly, I'm guessing that this is all just theory)

	Bert




Re: [PATCH] clean up release notes - pass 3

Posted by Stefan Hett <st...@egosoft.com>.
On 6/1/2016 1:57 PM, Stefan Sperling wrote:
> On Wed, Jun 01, 2016 at 12:37:08PM +0200, Stefan Hett wrote:
>> So with the change we are
>> actually resolving problems for more standard compliant and also for older
>> browsers working on that page.
> Do you have any evidence of browsers not accepting that link?
>
> Based on what Daniel Stenberg wrote here:
> https://daniel.haxx.se/blog/2016/05/11/my-url-isnt-your-url/
> I would expect that most browsers will happily accept it.
>
I don't have any evidence here and I would agree with your assumption 
that most likely most tools/browsers would accept/handle the old/current 
id-reference. Still, I would not make the blunt (no offense intended) 
statement about proposing that ALL browsers/tools do so (in relation to 
that, see Daniel's statement/proof that not all browsers accept URLs 
with an indefinite amount of slashes as in "http://///////foo.bar" :-) - 
btw. I enjoyed reading his blog during my lunchbreak - thanks ;) ).

IMO it shouldn't also matter much whether there is such a browser/tool 
out there and it also shouldn't matter much how widespread that 
browser/tool would be. The mere point of violating the standard there 
should be what matters for making the decision here. The question is 
just how much weight does that argument (violating the XHTML/HTML4.x 
standard) carry compared to the other arguments (aka: possibility to 
break existing links in the wild with the old/bad format).

I made my call here, but I can also fully understand if the rest of the 
world sees it different than I do. ;-)

-- 
Regards,
Stefan Hett


Re: [PATCH] clean up release notes - pass 3

Posted by Stefan Sperling <st...@elego.de>.
On Wed, Jun 01, 2016 at 12:37:08PM +0200, Stefan Hett wrote:
> So with the change we are
> actually resolving problems for more standard compliant and also for older
> browsers working on that page.

Do you have any evidence of browsers not accepting that link?

Based on what Daniel Stenberg wrote here:
https://daniel.haxx.se/blog/2016/05/11/my-url-isnt-your-url/
I would expect that most browsers will happily accept it.

Re: [PATCH] clean up release notes - pass 3

Posted by Stefan Hett <st...@egosoft.com>.
On 6/1/2016 9:47 AM, Stefan Sperling wrote:
> On Mon, May 16, 2016 at 03:44:58PM +0200, Stefan wrote:
>>    (issues): rename section id so it doesn't start with a number
> Is breaking section links like the one below worth it?
>
> It's not going to be a big problem for people to locate the right
> section on the page even if this link changes. But on the other hand,
> it's not a big problem if this page isn't 100% XHTML compliant, is it?
I suggested the patch under the (wrong) assumption that the id starting 
with a number would be invalid in HTML 5 as well. However, I just 
learned that this is valid in HTML 5. It's invalid in HTML 4.01 (or 
lower) as well as in XHTML though. So that sheds a different light on 
this. [1]

I'd still suggest to change that though mainly with the argument that 
browsers (and tools) which rely on the standard more closely and which 
do not support (and also do not fall back to) the HTML 5 style would not 
work at all with that link. I also think it's quite unlikely that there 
are many (if any) direct links out there which would break. So with the 
change we are actually resolving problems for more standard compliant 
and also for older browsers working on that page.

>> @@ -2463,9 +2460,9 @@
>>   <p>There are some known issues in the Subversion 1.8 releases.  These
>>   may be fixed in later 1.8.x releases.</p>
>>   
>> -<div class="h3" id="411-length-required">
>> +<div class="h3" id="length-required-411">
>>   <h3>1.8.0 and chunked Transfer-Encoding
>> -  <a class="sectionlink" href="#411-length-required"
>> +  <a class="sectionlink" href="#length-required-411"
>>       title="Link to this section">&para;</a>
>>   </h3>
>>   
>> @@ -2529,7 +2526,7 @@
>>   href="http://mail-archives.apache.org/mod_mbox/subversion-dev/201307.mbox/%3cCADkdwvQUaWaC5=AvwsthjSQWcn48tKHVfWoVCUHjLT=Abu13YA@mail.gmail.com>">this dev@ list post</a> for an example.</p>
>>   
>>   
>> -</div>  <!-- 411-length-required -->
>> +</div>  <!-- length-required-411 -->
>>   
>>   <div class="h3" id="mod_dav_svn-fsmap">
>>   <h3>mod_dav_svn Maps Requests to Local Filesystem
>>
[1] http://www.w3schools.com/tags/att_global_id.asp


-- 
Regards,
Stefan Hett