You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2006/08/21 13:01:15 UTC
[jira] Created: (HARMONY-1243) [luni] bootclasspath property issues
[luni] bootclasspath property issues
------------------------------------
Key: HARMONY-1243
URL: http://issues.apache.org/jira/browse/HARMONY-1243
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey Varlamov
There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1243) [luni] bootclasspath property
issues
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]
Paulex Yang reassigned HARMONY-1243:
------------------------------------
Assignee: Paulex Yang
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1243) [luni] bootclasspath property issues
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]
Alexey Varlamov updated HARMONY-1243:
-------------------------------------
Attachment: boot2.diff
Here is more robust implementation of property file parsing and bootclasspath composing.
The parser follows common property file syntax: any of '\r', '\n' are line separators and '#' or '!' mark comment line.
I still think that some of these functions better be added to portlib, namely:
char * str_concat (HyPortLibrary * portLibrary, ...);
int props_read_from_file(HyPortLibrary * portLibrary, const char *filename,
key_value_pair** properties, U_32 *number);
void props_free(HyPortLibrary * portLibrary, key_value_pair * properties);
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Attachments: boot2.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1243) [luni] bootclasspath property issues
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]
Alexey Varlamov closed HARMONY-1243.
------------------------------------
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1243) [luni] bootclasspath property
issues
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]
Paulex Yang resolved HARMONY-1243.
----------------------------------
Resolution: Fixed
Alexey, patch applied at revision r442941, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1243) [luni] bootclasspath property
issues
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=comments#action_12434594 ]
Alexey Varlamov commented on HARMONY-1243:
------------------------------------------
Paulex, everything looks OK, thank you very much.
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1243) [luni] bootclasspath property
issues
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=comments#action_12432491 ]
Alexey Varlamov commented on HARMONY-1243:
------------------------------------------
The last patch supersedes the first one.
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1243) [luni] bootclasspath property issues
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1243?page=all ]
Alexey Varlamov updated HARMONY-1243:
-------------------------------------
Attachment: harmony1243.diff
Rearranged code as discussed on dev-list: moved properties parsing to common library (luni/src/main/native/common).
> [luni] bootclasspath property issues
> ------------------------------------
>
> Key: HARMONY-1243
> URL: http://issues.apache.org/jira/browse/HARMONY-1243
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Attachments: boot2.diff, harmony1243.diff
>
>
> There are several issues with reading file "bootclasspath.properties" and setting "org.apache.harmony.boot.class.path" property:
> 1) readClassPathFromPropertiesFile() in modules\luni\src\main\native\luni\shared\luniglob.c loops infinitely if the file does not end with platform-dependent line separator;
> 2) The same function does not respect numbering of elements, simply concatenates in the same order as they appear in the file;
> 3) The same function uncoditionally rewrites the property, enforcing somewhat sinuous contract for a VM: the latter must load and init hyluni.dll(so) before updating this property.
> Besides, the name of this property better be defined in some exported header of the classlib...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira