You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:19:46 UTC
[GitHub] [incubator-seatunnel] BenJFan opened a new pull request, #1966: [Api-draft] add README.zh.md for new api
BenJFan opened a new pull request, #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1966: [Api-draft] add README.zh.md for new api
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966#discussion_r883568072
##########
seatunnel-connectors/seatunnel-connectors-seatunnel/README.zh.md:
##########
@@ -0,0 +1,62 @@
+## 目的
+Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+## 代码结构
+现阶段所有相关代码保存在`api-draft`分支上。
+为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
+### Example
+我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-examples`或`seatunnel-spark-examples`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1966: [Api-draft] add README.zh.md for new api
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966#issuecomment-1139439177
I will submit english version later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan merged pull request #1966: [Api-draft] add README.zh.md for new api
Posted by GitBox <gi...@apache.org>.
BenJFan merged PR #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1966: [Api-draft] add README.zh.md for new api
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966#discussion_r883715789
##########
seatunnel-connectors/seatunnel-connectors-seatunnel/README.zh.md:
##########
@@ -0,0 +1,62 @@
+## 目的
+Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+## 代码结构
+现阶段所有相关代码保存在`api-draft`分支上。
+为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
+### Example
+我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-examples`或`seatunnel-spark-examples`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
Review Comment:
```suggestion
我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-new-connector-example`或`seatunnel-spark-new-connector-example`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1966: [Api-draft] add README.zh.md for new api
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1966:
URL: https://github.com/apache/incubator-seatunnel/pull/1966#discussion_r883435673
##########
seatunnel-connectors/seatunnel-connectors-seatunnel/README.zh.md:
##########
@@ -0,0 +1,62 @@
+## 目的
+Because SeaTunnel design new API for connectors, 所以通过这篇文章来介绍新的接口以及新的代码结构，方便开发者快速的帮助新API和翻译层完善，以及开发出新的Connecotor.
+## 代码结构
+现阶段所有相关代码保存在`api-draft`分支上。
+为了和老的代码分开，方便现阶段的并行开发，以及降低merge的难度。我们为新的执行流程定义了新的模块
+### Example
+我们已经在`seatunnel-examples`中准备好了新版本的可本地执行Example程序，直接调用`seatunnel-flink-examples`或`seatunnel-spark-examples`中的`SeaTunnelApiExample`即可。这也是本地开发Connector经常会用到的调试方式。
Review Comment:
我等一下会新添加两个测试module`seatunnel-flink-new-connector-example`,`seatunnel-spark-new-connector-example`用于新的connector的本地测试
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org