You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "stalary (via GitHub)" <gi...@apache.org> on 2023/05/12 03:06:47 UTC
[GitHub] [doris] stalary opened a new pull request, #19570: MOD: support external catalog
stalary opened a new pull request, #19570:
URL: https://github.com/apache/doris/pull/19570
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/19537
## Problem summary
Row policy support external catalog
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19570: MOD: support external catalog
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19570:
URL: https://github.com/apache/doris/pull/19570#discussion_r1191867141
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StmtRewriter.java:
##########
@@ -1322,7 +1322,7 @@ public static boolean rewriteByPolicy(StatementBase statementBase, Analyzer anal
if (dbName == null) {
dbName = analyzer.getDefaultDb();
}
- Database db = currentEnv.getInternalCatalog().getDbOrAnalysisException(dbName);
+ DatabaseIf db = currentEnv.getCurrentCatalog().getDbOrAnalysisException(dbName);
Review Comment:
You need to use `tableRef.getName().getCtl()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #19570: [fix](row-policy) row policy supports external catalog
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary commented on PR #19570:
URL: https://github.com/apache/doris/pull/19570#issuecomment-1547063307
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19570: [fix](row-policy) row policy supports external catalog
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19570:
URL: https://github.com/apache/doris/pull/19570#issuecomment-1548810296
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #19570: [fix](row-policy) row policy supports external catalog
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #19570:
URL: https://github.com/apache/doris/pull/19570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #19570: [fix](row-policy) row policy supports external catalog
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary commented on PR #19570:
URL: https://github.com/apache/doris/pull/19570#issuecomment-1545223210
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19570: [fix](row-policy) row policy supports external catalog
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19570:
URL: https://github.com/apache/doris/pull/19570#issuecomment-1548810264
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19570: MOD: support external catalog
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19570:
URL: https://github.com/apache/doris/pull/19570#issuecomment-1545052040
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org