You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "wufangyong973 (via GitHub)" <gi...@apache.org> on 2026/09/25 09:09:31 UTC

[PR] Emit queued_duration metric when a task enters RUNNING via the execution API [airflow]

wufangyong973 opened a new pull request, #73711:
URL: https://github.com/apache/airflow/pull/73711

   The QUEUED -> RUNNING transition now happens in the /run execution API route instead of on the worker, so `TaskInstance.emit_state_change_metric(RUNNING)` never runs and the `queued_duration` metric goes missing.
   
   Emit it server side in `ti_run`, symmetric with the `scheduled_duration` metric the scheduler emits on the QUEUED transition. The `ti_run` route now selects `queued_dttm`, `end_date` and `queue` so the duration and tags are available, and skips re-emitting on a duplicate start request for the same host/pid.
   
   Adds two tests:
   - the metric is emitted on the QUEUED -> RUNNING transition with the right name, duration and tags
   - a duplicate start request does not emit it a second time
   
   Closes #63503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Emit queued_duration metric when a task enters RUNNING via the execution API [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #73711:
URL: https://github.com/apache/airflow/pull/73711#issuecomment-5829858887

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Emit queued_duration metric when a task enters RUNNING via the execution API [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.

kaxil closed pull request #73711: Emit queued_duration metric when a task enters RUNNING via the execution API
URL: https://github.com/apache/airflow/pull/73711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Emit queued_duration metric when a task enters RUNNING via the execution API [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.

kaxil commented on PR #73711:
URL: https://github.com/apache/airflow/pull/73711#issuecomment-5940882160

   Closing this. #67592 fixes the same issue in the same route and is approved by several maintainers. This version also brings back the `not ti.end_date` guard that #67592 dropped after review, since retried task instances have a valid queue wait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org