You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/31 09:10:21 UTC

Review Request 56117: Fixed mesos test helper createBasicAuthHeaders() on http header.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56117/
-----------------------------------------------------------

Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.


Repository: mesos


Description
-------

Fixed mesos test helper createBasicAuthHeaders() on http header.


Diffs
-----

  src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48 

Diff: https://reviews.apache.org/r/56117/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Re: Review Request 56117: Fixed mesos test helper createBasicAuthHeaders() on http header.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56117/#review163751
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 31, 2017, 8:08 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56117/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 8:08 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the initialization of http::Headers in mesos test helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48 
> 
> Diff: https://reviews.apache.org/r/56117/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 56117: Fixed mesos test helper createBasicAuthHeaders() on http header.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56117/
-----------------------------------------------------------

(Updated Jan. 31, 2017, 12:08 p.m.)


Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.


Repository: mesos


Description (updated)
-------

Fixed the initialization of http::Headers in mesos test helper.


Diffs (updated)
-----

  src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48 

Diff: https://reviews.apache.org/r/56117/diff/


Testing
-------

make check


Thanks,

Gilbert Song