You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2010/08/06 12:19:16 UTC

[jira] Created: (SLING-1631) Classloading problems when taglibs are used.

Classloading problems when taglibs are used.
--------------------------------------------

                 Key: SLING-1631
                 URL: https://issues.apache.org/jira/browse/SLING-1631
             Project: Sling
          Issue Type: Bug
          Components: Scripting
    Affects Versions: Scripting JSP 2.0.8
            Reporter: Carsten Ziegeler
            Assignee: Carsten Ziegeler
             Fix For: Scripting JSP 2.0.10


When taglibs are used together with jsp scripting there are several problems:
1. The taglib cache does not detect changes to taglibs (contained in bundles) like the general classloading mechanism through the dynamic classloader - this can result in inconsistencies and classloading problems.
2. The last modified check for taglibs does not work as expected. As soon as tags are used, they are considered as changed which results in recompilation of the jsp and of the tag where the second invalidates the classloader of the jsp. This classloader is later on used and then a classloading exception is thrown

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1631) Classloading problems when taglibs are used.

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-1631.
-------------------------------------

    Resolution: Fixed

Fixed in revision 982966
The taglib now uses the same logic for detecting taglib changes as the classloader uses for bundles
Simplified and fixed the timestamp checking for taglibs.

> Classloading problems when taglibs are used.
> --------------------------------------------
>
>                 Key: SLING-1631
>                 URL: https://issues.apache.org/jira/browse/SLING-1631
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting JSP 2.0.8
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Scripting JSP 2.0.10
>
>
> When taglibs are used together with jsp scripting there are several problems:
> 1. The taglib cache does not detect changes to taglibs (contained in bundles) like the general classloading mechanism through the dynamic classloader - this can result in inconsistencies and classloading problems.
> 2. The last modified check for taglibs does not work as expected. As soon as tags are used, they are considered as changed which results in recompilation of the jsp and of the tag where the second invalidates the classloader of the jsp. This classloader is later on used and then a classloading exception is thrown

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1631) Classloading problems when taglibs are used.

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898291#action_12898291 ] 

Carsten Ziegeler commented on SLING-1631:
-----------------------------------------

Another update to taglib loading: it now uses the same mechanism to detect if a dirty class loader is uses as is done for servlets.
This removes the need to restart the jsp scripting for taglib changes - this is already done by the class loading.

> Classloading problems when taglibs are used.
> --------------------------------------------
>
>                 Key: SLING-1631
>                 URL: https://issues.apache.org/jira/browse/SLING-1631
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting JSP 2.0.8
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Scripting JSP 2.0.10
>
>
> When taglibs are used together with jsp scripting there are several problems:
> 1. The taglib cache does not detect changes to taglibs (contained in bundles) like the general classloading mechanism through the dynamic classloader - this can result in inconsistencies and classloading problems.
> 2. The last modified check for taglibs does not work as expected. As soon as tags are used, they are considered as changed which results in recompilation of the jsp and of the tag where the second invalidates the classloader of the jsp. This classloader is later on used and then a classloading exception is thrown

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.