You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2018/02/09 22:22:00 UTC

[GitHub] jena pull request #355: JENA-1483: Promote with explicit promotion mode.

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/355

    JENA-1483: Promote with explicit promotion mode.

    Includes a fix for JENA-1478.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena promote-arg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #355
    
----
commit d8306ce261fe0bd07ede33426b9850ecd16f8b6e
Author: Andy Seaborne <an...@...>
Date:   2018-02-03T15:03:41Z

    promote(TxnType)

commit 5f99f5f3bb1a0e34d71048d1cec97f6b81bdbb64
Author: Andy Seaborne <an...@...>
Date:   2018-02-06T12:36:52Z

    promote(Promote mode)

commit e44ca811387b457b9bf1227ca87f07c6ac6fecf2
Author: Andy Seaborne <an...@...>
Date:   2018-02-09T21:54:24Z

    JENA-1478: Fix for contains(g,s,p,o)

----


---

[GitHub] jena pull request #355: JENA-1483: Promote with explicit promotion mode.

Posted by afs <gi...@git.apache.org>.

Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/355#discussion_r167362604
  
    --- Diff: pom.xml ---
    @@ -735,6 +735,7 @@
               <artifactId>maven-compiler-plugin</artifactId>
               <version>3.7.0</version>
               <configuration>
    +            <showDeprecation>false</showDeprecation>
    --- End diff --
    
    This crept in. We don't build with `-Xlint:deprecation` and all the output is
    ```
    [INFO] ....java: Some input files use or override a deprecated API.
    [INFO] ....java: Recompile with -Xlint:deprecation for details.
    ```
    so it does not given much information. Being an old codebase, and valuing legacy continuity, using/overriding deprecation happens.



---

[GitHub] jena pull request #355: JENA-1483: Promote with explicit promotion mode.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/355


---