You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2026/04/17 12:59:29 UTC
[PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
m1a2st opened a new pull request, #22081:
URL: https://github.com/apache/kafka/pull/22081
We have exposed several classes in org.apache.kafka.common.utils as
public APIs, which can be misleading since not all classes in this
package are intended for external use.
So move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #22081:
URL: https://github.com/apache/kafka/pull/22081#issuecomment-4358738598
Exposing only a portion of the classes in the same package is an anti-pattern to me. We had a PR to address similar issues for another package before.
I understand that some 'private' classes, such as Utils, are very popular downstream, so we will propose a formal KIP to address them and clarify their status for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #22081:
URL: https://github.com/apache/kafka/pull/22081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on PR #22081:
URL: https://github.com/apache/kafka/pull/22081#issuecomment-4360355791
@chia7712 : Sounds good. I was just wondering if we have already exposed classes that are not supposed to be public. I guess the answer is no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22081:
URL: https://github.com/apache/kafka/pull/22081#discussion_r3116024311
##########
clients/src/test/java/org/apache/kafka/common/utils/ByteBufferUnmapperTest.java:
##########
@@ -17,6 +17,7 @@
package org.apache.kafka.common.utils;
+import org.apache.kafka.common.utils.internals.ByteBufferUnmapper;
Review Comment:
please move this test to `org.apache.kafka.common.utils.internals` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22081:
URL: https://github.com/apache/kafka/pull/22081#discussion_r3116026216
##########
clients/src/test/java/org/apache/kafka/common/utils/ChunkedBytesStreamTest.java:
##########
@@ -16,6 +16,9 @@
*/
package org.apache.kafka.common.utils;
+import org.apache.kafka.common.utils.internals.BufferSupplier;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20297 Move ByteBufferUnmapper, BufferSupplier, ChunkedBytesStream into internal [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on PR #22081:
URL: https://github.com/apache/kafka/pull/22081#issuecomment-4356934384
@chia7712 : Are those classes actually exposed as public API? It seems that we don't include every class in org/apache/kafka/common/utils in the javadoc.
` include "**/org/apache/kafka/common/utils/Bytes.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org