You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/09 00:29:13 UTC
[GitHub] [arrow-site] kou opened a new pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
kou opened a new pull request #94:
URL: https://github.com/apache/arrow-site/pull/94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou closed pull request #94: ARROW-11486: [Website] Use Jekyll 4 and webpack to support Ruby 3.0 or later
Posted by GitBox <gi...@apache.org>.
kou closed pull request #94:
URL: https://github.com/apache/arrow-site/pull/94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] nealrichardson commented on pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-775587080
That's a really big diff, is that expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-775603425
Yes. But this may be overkill because this also includes Ruby 3.1 (this is not released yet. I'm building it from Git repository.) support.
If we like a small diff, adding `gem "webrick"` to `Gemfile` will be enough.
jekyll-assets depends on Nokogiri (an XML parser library for Ruby). It doesn't work with Ruby 3.1. (It's a Bundler's (package manager for Ruby) problem not Nokogiri.)
jekyll-assets isn't maintained well and we can drop jekyll-assets dependency by upgrading Jekyll to 4 from 3. Jekyll 4 has built-in SCSS support. This pull request includes Jekyll upgrade.
And this pull request also changes CSS/JavaScript management method to webpack from RubyGems.
Should we split this pull request to 1) just supporting Ruby 3.0 and 2) upgrading Jekyll to remove jekyll-assets dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-775585043
Preview: https://kou.github.io/arrow-site/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] github-actions[bot] commented on pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-775561006
https://issues.apache.org/jira/browse/ARROW-11486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on pull request #94: ARROW-11486: [Website] Add support for Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-777030348
Does anyone want to review this?
If nobody wants to do, I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on pull request #94: ARROW-11486: [Website] Use Jekyll 4 and webpack to support Ruby 3.0 or later
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-777801070
It makes sense!
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on pull request #94: ARROW-11486: [Website] Use Jekyll 4 and webpack to support Ruby 3.0 or later
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #94:
URL: https://github.com/apache/arrow-site/pull/94#issuecomment-777893775
I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org