[GitHub] [spark] cloud-fan commented on a change in pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29152:
URL: https://github.com/apache/spark/pull/29152#discussion_r457078204



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -1557,6 +1557,17 @@ class PlanResolutionSuite extends AnalysisTest {
     checkFailure("testcat.tab", "foo")
   }
 
+  test("SPARK-32356: forbid null type in create view") {
+    val sql1 = "create view v as select null as c"
+    val sql2 = "alter view v as select null as c"

Review comment:
       can we test temp view as well? also the df api `df.createTempView`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org