[GitHub] [hbase] busbey commented on a change in pull request #1002: HBASE-23663 Allow dot and hyphen in Profiler's URL

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #1002: HBASE-23663 Allow dot and hyphen in Profiler's URL
URL: https://github.com/apache/hbase/pull/1002#discussion_r364211960
 
 

 ##########
 File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileOutputServlet.java
 ##########
 @@ -39,7 +39,7 @@
   private static final Logger LOG = LoggerFactory.getLogger(ProfileOutputServlet.class);
   private static final int REFRESH_PERIOD = 2;
   // Alphanumeric characters, plus percent (url-encoding), equals, and ampersand
-  private static final Pattern ALPHA_NUMERIC = Pattern.compile("[a-zA-Z0-9\\%\\=\\&]*");
+  private static final Pattern ALPHA_NUMERIC = Pattern.compile("[a-zA-Z0-9%=&.\\-]*");
 
 Review comment:
   Comment above is now incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services