[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4068: Encryptor encrypt plaintext with null object

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #4068: Encryptor encrypt plaintext with null object
URL: https://github.com/apache/incubator-shardingsphere/pull/4068#discussion_r369905045
 
 

 ##########
 File path: encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/strategy/impl/AESEncryptor.java
 ##########
 @@ -70,7 +73,7 @@ public Object decrypt(final String ciphertext) {
         if (null == ciphertext) {
             return null;
         }
-        byte[] result = getCipher(Cipher.DECRYPT_MODE).doFinal(Base64.decodeBase64(String.valueOf(ciphertext)));
+        byte[] result = getCipher(Cipher.DECRYPT_MODE).doFinal(Base64.decodeBase64(ciphertext));
 
 Review comment:
   Why do you want to delete `String.valueOf()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services