You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/02/03 15:02:42 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #34030: GH-33709: [R] Remove suffix argument from semi_join and anti_join
thisisnic opened a new pull request, #34030:
URL: https://github.com/apache/arrow/pull/34030
The function signatures for `semi_join()` and `anti_join()` don't match those of dplyr. This PR removes the argument `suffix` from `anti_join()` and `semi_join()`. Is this change necessary/useful or just pedantic? Unsure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34030: GH-33709: [R] Remove suffix argument from semi_join and anti_join
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34030:
URL: https://github.com/apache/arrow/pull/34030#issuecomment-1418883773
Benchmark runs are scheduled for baseline = 1aea20bcf385de4369f0b1bff1cb2a2cdf2addff and contender = 32c713066d4ff04bde1f1ee867292ada4ca564ce. 32c713066d4ff04bde1f1ee867292ada4ca564ce is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/71bd8a3e02b940bf8687c69a8fa0df89...005a2063d6ba4115922dd28e8364fd79/)
[Failed :arrow_down:0.28% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b57b11b861be465dbf8baebafd8dd99a...d8b72c1c88a548abb3781ec11e853c7e/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/02f927af0cfe48b2b5b1b84bdbbd0dae...97bf7c8a920a434888ad6f0e43c3b8e6/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fd09759c34374aba85897bf1f5f2f9cd...c38264a9d0184a3eb95d18dcd0a9f775/)
Buildkite builds:
[Finished] [`32c71306` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2329)
[Failed] [`32c71306` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2357)
[Finished] [`32c71306` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2327)
[Finished] [`32c71306` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2348)
[Finished] [`1aea20bc` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2328)
[Finished] [`1aea20bc` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2356)
[Finished] [`1aea20bc` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2326)
[Finished] [`1aea20bc` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2347)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34030: GH-33709: [R] Remove suffix argument from semi_join and anti_join
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34030:
URL: https://github.com/apache/arrow/pull/34030#issuecomment-1415995684
* Closes: #33709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #34030: GH-33709: [R] Remove suffix argument from semi_join and anti_join
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #34030:
URL: https://github.com/apache/arrow/pull/34030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org