You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/06/17 09:54:34 UTC
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on a change in
pull request #274: CB-14187: (ios) Change the InAppBrowser to allow custom
schemes
timbru31 commented on a change in pull request #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#discussion_r294219479
##########
File path: src/ios/CDVUIInAppBrowser.m
##########
@@ -439,6 +439,21 @@ - (BOOL)isValidCallbackId:(NSString *)callbackId
return NO;
}
+- (BOOL)isAllowedScheme:(NSString*)scheme
Review comment:
This need to be added to the WKWebView, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org