You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2003/02/11 01:40:43 UTC
[PATCH] Re: svn commit: rev 4801 - in trunk/subversion: libsvn_fs
libsvn_fs/bdb libsvn_wc libsvn_subr libsvn_ra_local svnlook libsvn_client
bindings/ruby clients/cmdline tests/libsvn_wc libsvn_ra_svn libsvn_repos
libsvn_ra_dav svnserve
Karl Fogel wrote:
> dwhedon@tigris.org writes:
>
>>Calls to svn_error_createf() changed to make error messages clear
>>with respect to paths and urls. In most cases I simply add
>>quotation marks around paths and urls. In a few cases the messages
>>were changed so that quotation marks would not conflict with
>>apostrophes indicating possession.
>
>
> Nice!
Yes. Thanks. I had made a start but got distracted. Attached is a
patch (against r4825) for the few remaining ones that I could see, done
in the style that best matches each source file, or single quotes when
not obvious. Log message (substantially plagiarised):
Quotation marks added around paths, urls, external commands, etc. in
error messages (svn_error_createf and apr_psprintf) to make the messages
less ambiguous. In one case the message was changed slightly to avoid
an apostrophe indicating possession.
* subversion/libsvn_client/update.c
subversion/libsvn_fs/dag.c
subversion/libsvn_ra/ra_loader.c
subversion/libsvn_ra_dav/commit.c
subversion/libsvn_ra_dav/util.c
subversion/libsvn_repos/hooks.c
subversion/libsvn_subr/io.c
subversion/libsvn_wc/entries.c
subversion/libsvn_wc/log.c
subversion/libsvn_wc/props.c
subversion/libsvn_wc/update_editor.c
subversion/svnserve/serve.c
subversion/tests/libsvn_fs/fs-test.c : Fix error messages.
> So, it looks like we've standardized on forward single quotes for
> paths in error messages.
Not really. Yes, all the new ones that David put in. But overall,
- about 300 occurrences use '...'
- about 200 occurrences use `...'
- about 100 occurrences use "..."
- about 50 occurrences use (...) or [...]
- about 100 occurrences use just a colon before or after
That's %s strings in general, more than half of which are "paths" of
some kind. In many cases they are consistent within a file, but in
several cases they are not. But there's more variations than just the
type of quote marks... One step at a time.
- Julian
Re: [PATCH] Re: svn commit: rev 4801 - in trunk/subversion: libsvn_fs libsvn_fs/bdb libsvn_wc libsvn_subr libsvn_ra_local svnlook libsvn_client bindings/ruby clients/cmdline tests/libsvn_wc libsvn_ra_svn libsvn_repos libsvn_ra_dav svnserve
Posted by Sander Roobol <ph...@wanadoo.nl>.
Filed as issue #1181.
Sander
On Tue, Feb 11, 2003 at 01:40:43AM +0000, Julian Foad wrote:
> Karl Fogel wrote:
> >dwhedon@tigris.org writes:
> >
> >>Calls to svn_error_createf() changed to make error messages clear
> >>with respect to paths and urls. In most cases I simply add
> >>quotation marks around paths and urls. In a few cases the messages
> >>were changed so that quotation marks would not conflict with
> >>apostrophes indicating possession.
> >
> >
> >Nice!
>
> Yes. Thanks. I had made a start but got distracted. Attached is a
> patch (against r4825) for the few remaining ones that I could see, done
> in the style that best matches each source file, or single quotes when
> not obvious. Log message (substantially plagiarised):
>
> Quotation marks added around paths, urls, external commands, etc. in
> error messages (svn_error_createf and apr_psprintf) to make the messages
> less ambiguous. In one case the message was changed slightly to avoid
> an apostrophe indicating possession.
> [snip]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org