Re: [I] Make Eq with negative float zero compat with other engines [datafusion]

["sweb (via GitHub)" <gi...@apache.org>]

sweb commented on issue #11108:
URL: https://github.com/apache/datafusion/issues/11108#issuecomment-4610244610

   @Jefffrey thank you for finding my PR and linking it to this issue - I was not aware of it. I gave this issue a shot in https://github.com/apache/datafusion/pull/22628 however it comes with a performance regression - I am not sure whether this is possible without it because you need to do an additional check / transform where you go from `-0.0` to `0.0` - at least for floats.
   @alamb I ran the in-list bench and my first attempt regressed by 30%, doing a pre-check whether transform is required at all brought it down to ~10%. However, I have to admit that the benchmark was not very stable on my machine, so if my general approach is valid, I'd have to spend more time on measuring the precise impact of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org