[GitHub] [samza] prateekm commented on a change in pull request #1021: Adding writing of container.metadata file, and moving exception writing logic to DiagnosticsManager

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1021: Adding writing of container.metadata file, and moving exception writing logic to DiagnosticsManager
URL: https://github.com/apache/samza/pull/1021#discussion_r281734586
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/runtime/LocalContainerRunner.java
 ##########
 @@ -29,17 +31,25 @@
 import org.apache.samza.config.ShellCommandConfig;
 import org.apache.samza.container.SamzaContainer;
 import org.apache.samza.job.model.JobModel;
+import org.apache.samza.metrics.reporter.Metrics;
+import org.apache.samza.metrics.reporter.MetricsHeader;
+import org.apache.samza.metrics.reporter.MetricsSnapshot;
+import org.apache.samza.serializers.model.SamzaObjectMapper;
+import org.apache.samza.util.FileUtil;
 import org.apache.samza.util.SamzaUncaughtExceptionHandler;
+import org.apache.samza.util.Util;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.MDC;
-import java.util.Random;
+
 
 /**
  * Launches and manages the lifecycle for {@link SamzaContainer}s in YARN.
  */
 public class LocalContainerRunner {
   private static final Logger log = LoggerFactory.getLogger(LocalContainerRunner.class);
+  private static final String CONTAINER_METADATA_FILENAME_FORMAT = "%s.metadata"; // Filename: containerID.metadata
 
 Review comment:
   Maybe clarify that the containerID is the cluster manager container id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services