You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by JemDay <gi...@git.apache.org> on 2016/05/31 17:11:15 UTC
[GitHub] qpid-proton pull request: proton-j : Upgrade BouncyCastle
GitHub user JemDay opened a pull request:
https://github.com/apache/qpid-proton/pull/74
proton-j : Upgrade BouncyCastle
Changed to use a <provided> dependency.
Removed 'reflective' constructs.
Verified correct test operations with BC 1.48 and 1.54
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JemDay/qpid-proton master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 1cdd0ff54af9b7c04696af259b842b785da9c862
Author: Jem Day <jd...@paypal.com>
Date: 2016-05-27T21:30:31Z
Update to support newer BouncyCastle Implementations.
Change to 'provided' dependency to simplify coding.
Full tests pass with BC 1.48 and 1.54
commit ed450edb35617ba813b9b3ec649bf53fe230cc01
Author: Day, Jeremy(jday) <jd...@paypal.com>
Date: 2016-05-31T15:44:46Z
Merge pull request #1 from jday/master
For Internal Review
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #74: proton-j : Upgrade BouncyCastle
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton/pull/74
The CI builds are failing while running the cmake build (using it is outlined in DEVELOPERS.md) rather than the maven build. The cmake build creates a proton-j jar by itself for use in certain tests, a process which these changes break through introduction of a compile time dependency on bouncycastle that it doesn't accommodate because it didn't previously need to. Either the update needs to be made fully-reflective as before, or the cmake build updated to accommodate the new compilation dependency.
Some more general comments:
- The main module and tests are specifying difference versions of bouncycastle to use.
- If you include the JIRA title in the PR title, it will be updated by a bot upon PR open/comments/close.
- Please reference the JIRA in commit msg, i.e "PROTON-XYZ: msg".
- Please remove merge commits from PRs.
(Mentioning PROTON-1224 so it also gets updated)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #74: proton-j : Upgrade BouncyCastle
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay closed the pull request at:
https://github.com/apache/qpid-proton/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #74: proton-j : Upgrade BouncyCastle
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay commented on the issue:
https://github.com/apache/qpid-proton/pull/74
Closing PR .. will recreate
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request: proton-j : Upgrade BouncyCastle
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay commented on the pull request:
https://github.com/apache/qpid-proton/pull/74
I'm not sure what the CI build is doing to cause it to fail but i can confirm that "mvn clean test" works for me from the command line .. see attached
[build-log.txt](https://github.com/apache/qpid-proton/files/291766/build-log.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #74: proton-j : Upgrade BouncyCastle
Posted by JemDay <gi...@git.apache.org>.
Github user JemDay commented on the issue:
https://github.com/apache/qpid-proton/pull/74
OK .. i'll take a look at setting up a cmake environment and cleaning the commits..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org