You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/02/27 03:18:01 UTC

Re: Review Request 44112: Updated tests to use /state endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 2:18 a.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4509
    https://issues.apache.org/jira/browse/MESOS-4509


Repository: mesos


Description
-------

Updated tests to use /state endpoint instead of deprecated state.json endpoint.


Diffs
-----

  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44112/diff/


Testing
-------

make check


Thanks,

Joerg Schad


Re: Review Request 44112: Updated tests to use /state endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/
-----------------------------------------------------------

(Updated March 1, 2016, 9:39 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4817
    https://issues.apache.org/jira/browse/MESOS-4817


Repository: mesos


Description
-------

Updated tests to use /state endpoint instead of deprecated state.json endpoint.


Diffs
-----

  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44112/diff/


Testing
-------

make check


Thanks,

Joerg Schad


Re: Review Request 44112: Updated tests to use /state endpoint.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/#review121504
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 27, 2016, 2:18 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44112/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 2:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
>     https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated tests to use /state endpoint instead of deprecated state.json endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44112/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 44112: Updated tests to use /state endpoint.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/#review121069
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44110, 44111, 44112]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 2:18 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44112/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 2:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
>     https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated tests to use /state endpoint instead of deprecated state.json endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44112/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>