You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/17 21:54:00 UTC

[jira] [Work logged] (GOBBLIN-1088) Don't lowercase partition pattern config

     [ https://issues.apache.org/jira/browse/GOBBLIN-1088?focusedWorklogId=405005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405005 ]

ASF GitHub Bot logged work on GOBBLIN-1088:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Mar/20 21:53
            Start Date: 17/Mar/20 21:53
    Worklog Time Spent: 10m 
      Work Description: jack-moseley commented on pull request #2929: [GOBBLIN-1088] Don't lowercase partition pattern config
URL: https://github.com/apache/incubator-gobblin/pull/2929
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1088
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   Since partition pattern may contain dates (where case matters), we shouldn't lowercase it.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   trivial
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 405005)
    Remaining Estimate: 0h
            Time Spent: 10m

> Don't lowercase partition pattern config
> ----------------------------------------
>
>                 Key: GOBBLIN-1088
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1088
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)