You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by vj...@apache.org on 2020/05/29 13:34:04 UTC
[hbase] branch branch-2.3 updated: HBASE-24470 : Add store file
info when log meessages in HStore. (#1804)
This is an automated email from the ASF dual-hosted git repository.
vjasani pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 4a071f1 HBASE-24470 : Add store file info when log meessages in HStore. (#1804)
4a071f1 is described below
commit 4a071f11c9dc31a93d6c8b5aff7e52f6fe8efe11
Author: xincunSong <36...@qq.com>
AuthorDate: Fri May 29 21:28:57 2020 +0800
HBASE-24470 : Add store file info when log meessages in HStore. (#1804)
Signed-off-by: binlijin <bi...@gmail.com>
Signed-off-by: Viraj Jasani <vj...@apache.org>
---
.../main/java/org/apache/hadoop/hbase/regionserver/HStore.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
index f3a1222..556589f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
@@ -622,7 +622,7 @@ public class HStore implements Store, HeapSize, StoreConfigInformation,
file.closeStoreFile(evictOnClose);
}
} catch (IOException e) {
- LOG.warn("Could not close store file", e);
+ LOG.warn("Could not close store file {}", file, e);
}
}
throw ioe;
@@ -2829,13 +2829,15 @@ public class HStore implements Store, HeapSize, StoreConfigInformation,
file.initReader();
length = file.getReader().length();
} catch (IOException e) {
- LOG.trace("Failed to open reader when trying to compute store file size, ignoring", e);
+ LOG.trace("Failed to open reader when trying to compute store file size for {}, ignoring",
+ file, e);
} finally {
try {
file.closeStoreFile(
file.getCacheConf() != null ? file.getCacheConf().shouldEvictOnClose() : true);
} catch (IOException e) {
- LOG.trace("Failed to close reader after computing store file size, ignoring", e);
+ LOG.trace("Failed to close reader after computing store file size for {}, ignoring",
+ file, e);
}
}
return length;