You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/05/24 04:11:51 UTC

[GitHub] [beam] bvolpato opened a new issue, #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

bvolpato opened a new issue, #26853:
URL: https://github.com/apache/beam/issues/26853

   ### What would you like to happen?
   
   In case the FailedInserts PCollection is not consumed, BigQueryIO will silently drop records.
   
   This is probably working as intended, but I believe we should use a counter to expose this situation to users.
   
   
   ### Issue Priority
   
   Priority: 2 (default / most feature requests should be filed as P2)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [X] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #26853:
URL: https://github.com/apache/beam/issues/26853#issuecomment-1570833615

   Addressed in #26919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #26853:
URL: https://github.com/apache/beam/issues/26853#issuecomment-1561752757

   Part of the graph:
   
   <img width="288" alt="image" src="https://github.com/apache/beam/assets/8010435/da7881ab-251f-4f39-af26-77a091ea9670">
   
   Both Convert and StorageApiWriteUnsharded have DLQ sending to flatternErrors
   
   Codepaths where Exceptions gets suppressed:
   
   - in Convert
   
     https://github.com/apache/beam/blob/83e2e6197372283dcfeec4b6cd398368ed6c9899/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiConvertMessages.java#L146
   
   - in Write Records
     
     handled by a failedRowsReceiver:
   
     https://github.com/apache/beam/blob/83e2e6197372283dcfeec4b6cd398368ed6c9899/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java#L491
   
   Both send to a Flatten:
   
   https://github.com/apache/beam/blob/83e2e6197372283dcfeec4b6cd398368ed6c9899/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java#L148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn closed issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn closed issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts
URL: https://github.com/apache/beam/issues/26853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on issue #26853:
URL: https://github.com/apache/beam/issues/26853#issuecomment-1561723303

   cc @reuvenlax 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on issue #26853: [Feature Request]: BigQueryIO Storage Write should have metrics/counter for failed inserts

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on issue #26853:
URL: https://github.com/apache/beam/issues/26853#issuecomment-1570795702

   Generally speaking, we should probably at least warn for any pcollection that isn't consumed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org