You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/18 07:11:10 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1329: Revert "optimize: add lock"
LaurenceLiZhixin opened a new pull request #1329:
URL: https://github.com/apache/dubbo-go/pull/1329
Reverts apache/dubbo-go#1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1329: Revert "optimize: add lock"
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1329:
URL: https://github.com/apache/dubbo-go/pull/1329#issuecomment-882012975
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1329](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53f1f7a) into [master](https://codecov.io/gh/apache/dubbo-go/commit/a10996763e3e1ffa5cdbd80cb49319a4e3626994?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a109967) will **increase** coverage by `2.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
+ Coverage 55.69% 57.72% +2.02%
==========================================
Files 273 274 +1
Lines 12830 15173 +2343
==========================================
+ Hits 7146 8758 +1612
- Misses 4782 5484 +702
- Partials 902 931 +29
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `51.15% <ø> (+3.10%)` | :arrow_up: |
| [cluster/router/v3router/uniform\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvdW5pZm9ybV9yb3V0ZS5nbw==) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [config/instance/metadata\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2luc3RhbmNlL21ldGFkYXRhX3JlcG9ydC5nbw==) | `66.66% <0.00%> (-11.12%)` | :arrow_down: |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `86.66% <0.00%> (-4.25%)` | :arrow_down: |
| [filter/filter\_impl/token\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rva2VuX2ZpbHRlci5nbw==) | `87.50% <0.00%> (-4.17%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `44.82% <0.00%> (-3.96%)` | :arrow_down: |
| [protocol/rpc\_status.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcnBjX3N0YXR1cy5nbw==) | `45.08% <0.00%> (-3.86%)` | :arrow_down: |
| [cluster/cluster\_impl/interceptor\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvaW50ZXJjZXB0b3JfaW52b2tlci5nbw==) | `50.00% <0.00%> (-3.85%)` | :arrow_down: |
| [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <0.00%> (-3.64%)` | :arrow_down: |
| [...gistry/event/event\_publishing\_service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvZXZlbnRfcHVibGlzaGluZ19zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `42.10% <0.00%> (-3.61%)` | :arrow_down: |
| ... and [265 more](https://codecov.io/gh/apache/dubbo-go/pull/1329/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a109967...53f1f7a](https://codecov.io/gh/apache/dubbo-go/pull/1329?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1329: Revert "optimize: add lock"
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1329:
URL: https://github.com/apache/dubbo-go/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org