You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Cynerd (via GitHub)" <gi...@apache.org> on 2024/11/07 13:22:20 UTC

[PR] examples/pipe: fix write usage [nuttx-apps]

Cynerd opened a new pull request, #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829

   
   ## Summary
   write returns in case some bytes were written but not everything can fit.
   
   This wasn't the case in NuttX but commit
   d0680fd1bc51b7ead0b068fb24a31a144d22dc6c introduced this standard behavior.
   
   ## Impact
   This should fix CI as reported in https://github.com/apache/nuttx/pull/14667#issuecomment-2461197521.
   ## Testing
   `pipe` was executed on custom same7 board and passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462814111

   @Cynerd I ran the exact same steps and it works OK: https://gist.github.com/nuttxpr/bdb03952f774e711bafc4e7ae7d329c2
   
   In the earlier log: `git clone https://github.com/apache/nuttx-apps apps`
   
   That's the only difference I think.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462266087

   Thanks @Cynerd: I cloned your branch and [enabled all the builds](https://github.com/nuttxpr/nuttx-apps/commit/fc85439e8b3b681583225cf6790994040cff91d6). I'll check the results here: https://github.com/nuttxpr/nuttx-apps/actions/runs/11724108240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462601947

   rv-virt:citest also failed 12 hours ago, according to nuttx-dashboard.org 
   https://gist.github.com/jerpelea/45f67d6dd6efba585b7a1e7a1f2c1216#file-ci-risc-v-05-log-L78
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462605924

   I mean this file: nuttx/boards/arm/imx6/sabre-6quad/configs/citest/logs/sabre-6quad/qemu/sabre-6quad_20241107_162834.log
   
   It is log from pexpect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462772097

   @lupyuen can you please compare what you are doing with what I am doing? The full log of attempt in the docker: https://gist.github.com/Cynerd/81262ceaa32ac5719b453269e620cb0c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462744197

   Or something special about the way QEMU runs inside Docker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462231910

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   No.  This PR description lacks crucial information.
   
   Here's what's missing and why it's important:
   
   * **Insufficient Summary:**  "write returns..." is too vague.  What *specifically* was changed in the code? Which function(s) were modified?  What was the previous, incorrect behavior?  The reference to the commit hash is helpful but insufficient; explain the change in human-readable terms.  A link to the relevant NuttX Issue is missing.
   * **Incomplete Impact Assessment:**  While it mentions fixing a CI issue, it doesn't fully address all the impact points.  Consider:
       * **Impact on user:**  Does this change the behavior of applications using `write`?  Even if the change aligns with POSIX, it's still a change that might affect user code.
       * **Impact on hardware:**  Unclear.  While tested on a SAME7 board, does this change affect other architectures?  Explicitly state "NO" or provide details if "YES."  Similarly for drivers.
       * **Impact on documentation:** Does this change require documentation updates?
       * **Impact on compatibility:** Explicitly address backward compatibility.  Does this change break existing NuttX applications?
       * **Impact on security:**  Consider if this change has any security ramifications. Even if the answer is "NO," it should be explicitly stated.
   * **Inadequate Testing:**  "pipe was executed..." is far too vague. What were the specific test cases? What were the *expected* outputs before and after the change? The provided log sections are empty.  Provide concrete examples of commands and their outputs, demonstrating both the previous broken behavior and the corrected behavior.  Include details about the build host used for testing.
   
   
   **In short:** The PR description needs to be significantly more detailed to meet the NuttX requirements.  It must clearly articulate the change, its rationale, its impact across different aspects of the system, and provide verifiable testing evidence.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462567317

   @lupyuen is there a way to get logs from CI for arm-02 board sabre-6quad. That seems to be the only one that failed. Other runs seem to be running fast again. The only one that failed is sabre-6quad. I am trying to run tests for it locally and it passes. I see that tests create logs in my case, but there is no such file in the arm-02 artifact, and thus, I am unable to find out where it actually failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462667429

   Is this correct? https://gist.github.com/nuttxpr/67b041a3a537343ebf08b46ed4b68b6b
   ```text
   ABDGHIJKNOPQ
   CHelloWorld: Constructor: mSecret=42
   
   NuttShell (NSH) NuttX-12.7.0
   nsh> pipe
   
   pipe_main: Performing FIFO test
   open_write_only: Opening FIFO for write access
   open_write_only: Waiting for open_write_only thread
   pipe_main: open_write_only returned 0
   transfer_test: fdin=4 fdout=3
   transfer_test: Starting transfer_reader thread
   transfer_test: Starting transfer_writer thread
   transfer_test: Waiting for transfer_writer thread
   transfer_reader: started
   transfer_writer: started
   transfer_writer: Unexpected write size=10
   transfer_test: transfer_writer returned 2
   transfer_test: Waiting for transfer_reader thread
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462578037

   @Cynerd Sorry do you mean this log? I ran sabre-6quad:citest 3 hours ago:
   https://github.com/NuttX/nuttx/actions/runs/11722647465/job/32652723982#step:7:115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462741435

   Well it should have been https://gist.github.com/Cynerd/7285ef024ee7bf49518ee538ba9abc27. It seems that really this for some reason doesn't work in case of sabre-6quad. This just blocks it right after first test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462751405

   > Or something special about the way QEMU runs inside Docker?
   
   Possibly.. but why just for this one specific board? Or is it the only board that runs tests in Qemu? I am trying to run it in docker as well now. Will see..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462297358

   > Thanks @Cynerd: I cloned your branch and [enabled all the builds](https://github.com/nuttxpr/nuttx-apps/commit/fc85439e8b3b681583225cf6790994040cff91d6). I'll check the results here: https://github.com/nuttxpr/nuttx-apps/actions/runs/11724108240
   
   It still seems to fail for what ever reason. I will try those tests locally and see what is going on there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462761485

   BTW rv-virt:citest is also failing with QEMU inside Docker:
   https://gist.github.com/jerpelea/45f67d6dd6efba585b7a1e7a1f2c1216#file-ci-risc-v-05-log-L78


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462758679

   Anyway I would be for merging this to fix at least CI runtime. The issue with sabre-6quad we could solve down the line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462638022

   Sorry what's the command to run citest? I have compiled sabre-6quad:citest in Docker, but I'm not sure how to run it:
   ```bash
   tools/configure.sh sabre-6quad:citest
   make
   ## What next?
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] examples/pipe: fix write usage [nuttx-apps]

Posted by "Cynerd (via GitHub)" <gi...@apache.org>.
Cynerd commented on PR #2829:
URL: https://github.com/apache/nuttx-apps/pull/2829#issuecomment-2462640269

   ```
   python3 -m pytest -m qemu tools/ci/testrun/script -B sabre-6quad -P . -L boards/arm/imx6/sabre-6quad/configs/citest/logs/sabre-6quad/qemu -R qemu -k 'pipe'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org