[GitHub] [solr] janhoy commented on a diff in pull request #1185: SOLR-16553 and SOLR-16559

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1031236174


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
 
   // Adds modules to shared classpath
   private void initModules() {
+    Path solrInstallDir = getSolrInstallDir();
+    if (solrInstallDir == null) {
+      return;

Review Comment:
   I'm not a fan of returning null to handle exceptional cases. Why not catch the exception instead? 
   
   And certainly not a fan of silenlty returning like this. At the very least, it should do a check to see if any modules are requested, and throw exception if they are but we cannot load them due to, in this case, a configuration error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org