You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/16 11:08:36 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
MaxGekk opened a new pull request #28842:
URL: https://github.com/apache/spark/pull/28842
### What changes were proposed in this pull request?
Move creation of `dateFormatter` and `timestampFormatter` from the constructor of the `HiveResult` object to `HiveResult. hiveResultString()`. This allows to resolve time zone ID from Spark's session time zone `spark.sql.session.timeZone` and create date/timestamp formatters only once before collecting `java.sql.Timestamp`/`java.sql.Date` values.
### Why are the changes needed?
To fix perf regression comparing to Spark 2.4
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- By existing test suite `HiveResultSuite` and etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644699370
**[Test build #124123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124123/testReport)** for PR 28842 at commit [`a152d94`](https://github.com/apache/spark/commit/a152d94485b9d53521175b5b6574c8233d25e744).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644789874
**[Test build #124126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124126/testReport)** for PR 28842 at commit [`650a858`](https://github.com/apache/spark/commit/650a8582b932edb0e9389061f70de0d03a2aa482).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644699370
**[Test build #124123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124123/testReport)** for PR 28842 at commit [`a152d94`](https://github.com/apache/spark/commit/a152d94485b9d53521175b5b6574c8233d25e744).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645176412
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28771/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645176056
**[Test build #124155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124155/testReport)** for PR 28842 at commit [`d55d69f`](https://github.com/apache/spark/commit/d55d69f93bbcc34fe0c1308041d6a747431b8245).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644865913
**[Test build #124123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124123/testReport)** for PR 28842 at commit [`a152d94`](https://github.com/apache/spark/commit/a152d94485b9d53521175b5b6574c8233d25e744).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` case class TimeFormatters(date: DateFormatter, timestamp: TimestampFormatter)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644866961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644866961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28842:
URL: https://github.com/apache/spark/pull/28842#discussion_r441297086
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
##########
@@ -72,47 +90,32 @@ object HiveResult {
}
}
- // We can create the date formatter only once because it does not depend on Spark's
- // session time zone controlled by the SQL config `spark.sql.session.timeZone`.
- // The `zoneId` parameter is used only in parsing of special date values like `now`,
- // `yesterday` and etc. but not in date formatting. While formatting of:
- // - `java.time.LocalDate`, zone id is not used by `DateTimeFormatter` at all.
- // - `java.sql.Date`, the date formatter delegates formatting to the legacy formatter
- // which uses the default system time zone `TimeZone.getDefault`. This works correctly
- // due to `DateTimeUtils.toJavaDate` which is based on the system time zone too.
- private val dateFormatter = DateFormatter(
- format = DateFormatter.defaultPattern,
- // We can set any time zone id. UTC was taken for simplicity.
- zoneId = ZoneOffset.UTC,
- locale = DateFormatter.defaultLocale,
- // Use `FastDateFormat` as the legacy formatter because it is thread-safe.
- legacyFormat = LegacyDateFormats.FAST_DATE_FORMAT,
- isParsing = false)
- private def timestampFormatter = TimestampFormatter.getFractionFormatter(
- DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone))
-
/** Formats a datum (based on the given data type) and returns the string representation. */
- def toHiveString(a: (Any, DataType), nested: Boolean = false): String = a match {
+ def toHiveString(
+ a: (Any, DataType),
Review comment:
nit: 4 space indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645178845
The last commit updates indentation only, I'm merging it to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645193060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645176405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644956984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645176056
**[Test build #124155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124155/testReport)** for PR 28842 at commit [`d55d69f`](https://github.com/apache/spark/commit/d55d69f93bbcc34fe0c1308041d6a747431b8245).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645176405
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644790532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644956984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644953420
@cloud-fan @juliuszsompolski @HyukjinKwon @bogdanghit @gatorsmile Please, take a look at this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644955977
**[Test build #124126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124126/testReport)** for PR 28842 at commit [`650a858`](https://github.com/apache/spark/commit/650a8582b932edb0e9389061f70de0d03a2aa482).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645192952
**[Test build #124155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124155/testReport)** for PR 28842 at commit [`d55d69f`](https://github.com/apache/spark/commit/d55d69f93bbcc34fe0c1308041d6a747431b8245).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644789874
**[Test build #124126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124126/testReport)** for PR 28842 at commit [`650a858`](https://github.com/apache/spark/commit/650a8582b932edb0e9389061f70de0d03a2aa482).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645193067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124155/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644696793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-645193060
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644790532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28842: [SPARK-32006][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28842:
URL: https://github.com/apache/spark/pull/28842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28842: [WIP][SQL] Create date/timestamp formatters once before collect in `hiveResultString()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28842:
URL: https://github.com/apache/spark/pull/28842#issuecomment-644696793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org