[jira] [Commented] (KAFKA-9623) Streams will attempt to commit during shutdown if rebalance is in progress

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047123#comment-17047123 ] 

ASF GitHub Bot commented on KAFKA-9623:
---------------------------------------

guozhangwang commented on pull request #8190: KAFKA-9623: Keep polling until the task manager is no longer rebalancing in progress
URL: https://github.com/apache/kafka/pull/8190
 
 
   This bug is found via the flaky SmokeTestDriverIntegrationTest. Without this PR the test fails every 3-4 times, after this issue is fixed we've run the test 20+ locally without error.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Streams will attempt to commit during shutdown if rebalance is in progress
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-9623
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9623
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>            Priority: Major
>
> This will throw a retriable `RebalanceInProgressException` which Streams does not currently expect. 
> A possible fix is to change the condition of while(isRunning()) inside runLoop to sth. like isRunning() || !taskManager.rebalanceInProgress(), and within an iteration after we’ve added the records we will check isRunning() again and if false we would skip processing any records anyways.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)