You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/19 01:53:21 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
panbingkun opened a new pull request, #41224:
URL: https://github.com/apache/spark/pull/41224
### What changes were proposed in this pull request?
This PR aims to upgrade `sbt-pom-reader` from 2.2.0 to 2.4.0.
### Why are the changes needed?
Since v2.3.0, organization has moved from `` to `com.github.sbt`
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
URL: https://github.com/apache/spark/pull/41224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41224:
URL: https://github.com/apache/spark/pull/41224#issuecomment-1553928960
Thank you for update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41224:
URL: https://github.com/apache/spark/pull/41224#issuecomment-1553915757
> Oh, could you take a look at the build error? This looks like a breaking change.
>
> ```
> [error] /home/runner/work/spark/spark/project/SparkBuild.scala:34:21: object sbt is not a member of package com.typesafe
> [error] import com.typesafe.sbt.pom.{PomBuild, SbtPomKeys}
> ```
Ok, let me check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41224:
URL: https://github.com/apache/spark/pull/41224#issuecomment-1554000199
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #41224:
URL: https://github.com/apache/spark/pull/41224#discussion_r1198474441
##########
project/plugins.sbt:
##########
@@ -43,6 +43,6 @@ libraryDependencies += "org.ow2.asm" % "asm-commons" % "9.4"
addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.8.3")
-addSbtPlugin("com.typesafe.sbt" % "sbt-pom-reader" % "2.2.0")
+addSbtPlugin("com.github.sbt" % "sbt-pom-reader" % "2.4.0")
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41224: [SPARK-43582][BUILD] Upgrade `sbt-pom-reader` to 2.4.0
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41224:
URL: https://github.com/apache/spark/pull/41224#discussion_r1198493858
##########
project/SparkBuild.scala:
##########
@@ -31,7 +31,7 @@ import sbt.Keys._
import sbt.librarymanagement.{ VersionNumber, SemanticSelector }
import com.etsy.sbt.checkstyle.CheckstylePlugin.autoImport._
import com.simplytyped.Antlr4Plugin._
-import com.typesafe.sbt.pom.{PomBuild, SbtPomKeys}
+import sbtpomreader.{PomBuild, SbtPomKeys}
Review Comment:
https://github.com/sbt/sbt-pom-reader/blob/main/src/main/scala/sbtpomreader/PomBuild.scala#L1~L9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org