You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/07/22 15:22:26 UTC
[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #638: OAK-9855 - Enable for Lucene the tests common to Lucene and Elastic that are failing only with Elastic
nfsantos opened a new pull request, #638:
URL: https://github.com/apache/jackrabbit-oak/pull/638
In the common tests that are passing on Lucene but failing on ES, move the @Ignore annotation from the base class to the ES implementation of the tests, so that the Lucene test is executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #638: OAK-9855 - Enable for Lucene the tests common to Lucene and Elastic that are failing only with Elastic
Posted by GitBox <gi...@apache.org>.
thomasmueller commented on code in PR #638:
URL: https://github.com/apache/jackrabbit-oak/pull/638#discussion_r928564981
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDescendantSpellcheckCommonTest.java:
##########
@@ -38,4 +40,23 @@ protected Repository createJcrRepository() {
return jcr.createRepository();
}
+ //TODO ES Failing: this seems to be similar to
+ //https://discuss.elastic.co/t/elasticsearch-suggestion-completes-return-incorrect-number-of-suggestions/214522
+ //Even increasing the suggester query size the number of max results seems to be fixed to 5
+ @Test
+ @Ignore("Failing on ES")
Review Comment:
We often use the Jira issue id in the ignore annotation. So what about opening a new Oak Jira issue to fix this particular problem, and then use the id here? E.g. @Ignore("OAK-123456")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #638: OAK-9855 - Enable for Lucene the tests common to Lucene and Elastic that are failing only with Elastic
Posted by GitBox <gi...@apache.org>.
thomasmueller commented on code in PR #638:
URL: https://github.com/apache/jackrabbit-oak/pull/638#discussion_r928564981
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDescendantSpellcheckCommonTest.java:
##########
@@ -38,4 +40,23 @@ protected Repository createJcrRepository() {
return jcr.createRepository();
}
+ //TODO ES Failing: this seems to be similar to
+ //https://discuss.elastic.co/t/elasticsearch-suggestion-completes-return-incorrect-number-of-suggestions/214522
+ //Even increasing the suggester query size the number of max results seems to be fixed to 5
+ @Test
+ @Ignore("Failing on ES")
Review Comment:
We often use the Jira issue id in the ignore annotation. So what about opening a new Oak Jira issue to fix this particular problem, and then use the id here? E.g. `@Ignore("OAK-123456")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] thomasmueller merged pull request #638: OAK-9855 - Enable for Lucene the tests common to Lucene and Elastic that are failing only with Elastic
Posted by GitBox <gi...@apache.org>.
thomasmueller merged PR #638:
URL: https://github.com/apache/jackrabbit-oak/pull/638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #638: OAK-9855 - Enable for Lucene the tests common to Lucene and Elastic that are failing only with Elastic
Posted by GitBox <gi...@apache.org>.
nfsantos commented on code in PR #638:
URL: https://github.com/apache/jackrabbit-oak/pull/638#discussion_r929003418
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDescendantSpellcheckCommonTest.java:
##########
@@ -38,4 +40,23 @@ protected Repository createJcrRepository() {
return jcr.createRepository();
}
+ //TODO ES Failing: this seems to be similar to
+ //https://discuss.elastic.co/t/elasticsearch-suggestion-completes-return-incorrect-number-of-suggestions/214522
+ //Even increasing the suggester query size the number of max results seems to be fixed to 5
+ @Test
+ @Ignore("Failing on ES")
Review Comment:
I have created issues for all the failing tests and referenced them on the `@Ignore` tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org