You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 02:13:24 UTC

[GitHub] [flink] xintongsong opened a new pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

xintongsong opened a new pull request #12308:
URL: https://github.com/apache/flink/pull/12308


   ##  What is the purpose of the change
   
   This PR fixes test instability for `AbstractHadoopFileSystemITTest`. The problem was that a timeout for checking file status is shared by all test cases and may fail if previous test executions take too long.
   
   ## Brief change log
   
   Set independent timeout for each file status checking.
   
   ## Verifying this change
   
   This PR is a fix for existing test cases.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633343124

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4 (Mon May 25 02:15:28 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

aljoscha commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633544392


   Thanks for the PR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633345808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

aljoscha commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633498751


   The changes look good! But maybe 5 seconds of deadline is not enough?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633345808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2094",
       "triggerID" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2094) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633343124

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit dd21b020a56c9e5c237897bdde65311822ee9157 (Fri Oct 16 10:54:34 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

aljoscha commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633542896


   Ok, I think that's good to merge then! I'll merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633345808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2094",
       "triggerID" : "da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da01a91ea8eccf9bdc1dee6e32b1f5a9b06b0cc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2094) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

aljoscha closed pull request #12308:
URL: https://github.com/apache/flink/pull/12308


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

xintongsong commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633541577


   I've increased it to 30s.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #12308: [FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.

Posted by GitBox <gi...@apache.org>.

xintongsong commented on pull request #12308:
URL: https://github.com/apache/flink/pull/12308#issuecomment-633528153


   @aljoscha What value do you suggest? Maybe change it back to 30s? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org