[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #548: WIP [YUNIKORN-1716] Improve the performance of baseNodeCollection.getNodeIteratorInternal()

["pbacsko (via GitHub)" <gi...@apache.org>]

pbacsko commented on code in PR #548:
URL: https://github.com/apache/yunikorn-core/pull/548#discussion_r1219394647


##########
pkg/scheduler/objects/node_iterator.go:
##########
@@ -30,6 +32,8 @@ type NodeIterator interface {
 	Next() *Node
 	// reset the iterator to a clean state
 	Reset()
+
+	ForEachNode(func(*Node) bool)

Review Comment:
   This makes it not really an iterator anymore. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org