You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by da...@apache.org on 2023/08/19 16:12:44 UTC

[doris] branch opt_memtable_speed updated: [debug](move-memtable) add debug logs in sink v2 close (#23209)

This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch opt_memtable_speed
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/opt_memtable_speed by this push:
     new da8bd1a417 [debug](move-memtable) add debug logs in sink v2 close (#23209)
da8bd1a417 is described below

commit da8bd1a4178c43d6c5c07a41f066d59076675937
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Sun Aug 20 00:12:38 2023 +0800

    [debug](move-memtable) add debug logs in sink v2 close (#23209)
---
 be/src/vec/sink/vtablet_sink_v2.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/be/src/vec/sink/vtablet_sink_v2.cpp b/be/src/vec/sink/vtablet_sink_v2.cpp
index a748262ece..567b259af3 100644
--- a/be/src/vec/sink/vtablet_sink_v2.cpp
+++ b/be/src/vec/sink/vtablet_sink_v2.cpp
@@ -511,6 +511,7 @@ Status VOlapTableSinkV2::close(RuntimeState* state, Status exec_status) {
         COUNTER_SET(_row_distribution_timer, (int64_t)_row_distribution_watch.elapsed_time());
         COUNTER_SET(_validate_data_timer, _block_convertor->validate_data_ns());
 
+        LOG(INFO) << "starting to close DeltaWriters";
         {
             SCOPED_TIMER(_close_writer_timer);
             // close all delta writers
@@ -525,6 +526,7 @@ Status VOlapTableSinkV2::close(RuntimeState* state, Status exec_status) {
             _delta_writer_for_tablet.reset();
         }
 
+        LOG(INFO) << "closed DeltaWriters, starting to send CLOSE_LOAD";
         {
             // send CLOSE_LOAD to all streams, return ERROR if any
             RETURN_IF_ERROR(std::transform_reduce(
@@ -534,6 +536,7 @@ Status VOlapTableSinkV2::close(RuntimeState* state, Status exec_status) {
                     [this](auto&& entry) { return _close_load(entry.first); }));
         }
 
+        LOG(INFO) << "sent CLOSE_LOAD, starting wait for reports";
         {
             SCOPED_TIMER(_close_load_timer);
             while (_pending_reports.load() > 0) {
@@ -543,6 +546,7 @@ Status VOlapTableSinkV2::close(RuntimeState* state, Status exec_status) {
             }
         }
 
+        LOG(INFO) << "got all reports, starting StreamClose";
         {
             SCOPED_TIMER(_close_stream_timer);
             // close streams
@@ -554,6 +558,7 @@ Status VOlapTableSinkV2::close(RuntimeState* state, Status exec_status) {
             _stream_pool_for_node.reset();
         }
 
+        LOG(INFO) << "finished StreamClose, starting update commit info";
         std::vector<TTabletCommitInfo> tablet_commit_infos;
         for (auto& [tablet_id, backends] : _tablet_success_map) {
             for (int64_t be_id : backends) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org