You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (Commented) (JIRA)" <ji...@apache.org> on 2012/02/27 00:08:48 UTC
[jira] [Commented] (QPID-3867)
AMQQueueMBean#clearQueue|moveMessages|copyMessages should be certain to
rollback transactions in the event of exception
[ https://issues.apache.org/jira/browse/QPID-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216958#comment-13216958 ]
Rob Godfrey commented on QPID-3867:
-----------------------------------
One small comment from me:
Since we're changing the interface on AMQQueue anyway, I would suggest it would be nicer for the move/copy to take the destination queue as an AMQQueue rather than as a string which needs to be looked up. Obviously the methods still need to check that the passed queue != this, and that the queue is on the same vhost.
Not a blocker by any means, rest of the patch looked good to me.
> AMQQueueMBean#clearQueue|moveMessages|copyMessages should be certain to rollback transactions in the event of exception
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3867
> URL: https://issues.apache.org/jira/browse/QPID-3867
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.15
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Critical
>
> AMQQueueMBean#clearQueue|moveMessages|copyMessages all leave open that possibility that a LocalTransaction goes uncommitted (or unrolledback) in the event of exception.
> This will lead to uncontrolled store growth when used with BDB as would block the action of the cleaner thread.
> A finally block should be used to ensure that transaction is rolled back on any exception.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org