You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2019/02/24 14:11:55 UTC

[Bug 63203] New: Unit Tests : Replace use of @Deprecated by @VisibleForTesting

https://bz.apache.org/bugzilla/show_bug.cgi?id=63203

            Bug ID: 63203
           Summary: Unit Tests : Replace use of @Deprecated by
                    @VisibleForTesting
           Product: JMeter
           Version: 5.1
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com
  Target Milestone: JMETER_5.2

To discourage use of Default Constructors added for JUnit, we use @Deprecated.

But this is not very nice for quality auditing tools nor very readable.

This enhancement will introduce replacement of this by a new annotation
extracted from under ASL2 license:

https://github.com/aosp-mirror/platform_frameworks_base/blob/8b2c3a14603d163d7564e6f60286995079687690/core/java/com/android/internal/annotations/VisibleForTesting.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63203] Unit Tests : Replace use of @Deprecated by @VisibleForTesting for methods/constructors/classes made public for Unit Testing only

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63203

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 24 14:14:09 2019
New Revision: 1854261

URL: http://svn.apache.org/viewvc?rev=1854261&view=rev
Log:
Bug 63203 - Unit Tests : Replace use of @Deprecated by @VisibleForTesting for
methods/constructors/classes made public for Unit Testing only
Bugzilla Id: 63203

Added:
    jmeter/trunk/src/jorphan/org/apache/jorphan/documentation/
   
jmeter/trunk/src/jorphan/org/apache/jorphan/documentation/VisibleForTesting.java
  (with props)
Modified:
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63203] Unit Tests : Replace use of @Deprecated by @VisibleForTesting for methods/constructors/classes made public for Unit Testing only

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63203

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 24 20:12:09 2019
New Revision: 1854280

URL: http://svn.apache.org/viewvc?rev=1854280&view=rev
Log:
Fix javadoc errors

Modified:
   
jmeter/trunk/src/jorphan/org/apache/jorphan/documentation/VisibleForTesting.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63203] Unit Tests : Replace use of @Deprecated by @VisibleForTesting for methods/constructors/classes made public for Unit Testing only

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63203

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
            Summary|Unit Tests : Replace use of |Unit Tests : Replace use of
                   |@Deprecated by              |@Deprecated by
                   |@VisibleForTesting          |@VisibleForTesting for
                   |                            |methods/constructors/classe
                   |                            |s made public for Unit
                   |                            |Testing only

-- 
You are receiving this mail because:
You are the assignee for the bug.